Review Request 67169: WIP: Made use of generic `Error` stringification.

[Benjamin Bannier <be...@mesosphere.io>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67169/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

WIP: Made use of generic `Error` stringification.


Diffs
-----

  src/appc/spec.cpp 8213d41b5cd3a013b5ef048a33395cc44138a9f4 
  src/authentication/executor/jwt_secret_generator.cpp 1d7c010a111c8dfcb574e8044694d670b641cf33 
  src/authentication/http/basic_authenticator_factory.cpp bfc08358d94b216ba9453c5396f59f3f6a763c69 
  src/authentication/http/combined_authenticator.cpp 836afc537d11361058b9c2c1679639913168133b 
  src/checks/checker.cpp 6d01349f5a6b7df90c20c2014ad850f312e98593 
  src/checks/checker_process.cpp 7e484510b4fc2b94d4d4385dfa8f68bdd76e6093 
  src/checks/health_checker.cpp 497549540ea90826e6d266024af2b76e7bade8e4 
  src/checks/tcp_connect.cpp 2e9262ed773976e0a654e8d4ced676e92eaee2c2 
  src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
  src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 
  src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
  src/common/http.cpp 0098c140cb196af78de37183b8b6bdbd4bd24b8d 
  src/common/parse.hpp 03814e3112a043a1001764b316b9d49501d33665 
  src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
  src/common/resources.cpp 192d086e60b81c0ae8e26d4120beee2034f63d3e 
  src/common/validation.cpp 74450df1ff0eb2a892f082c60416307ecfcd9e34 
  src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
  src/csi/paths.cpp 772d960d96d481949cf25bc464e39e1ec15cd27d 
  src/docker/docker.cpp d000a902f1acefa37adc28b2e21a9af59438cbc7 
  src/docker/executor.cpp 572594a110aa4b51a698b176287b6ff823b2dd07 
  src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9 
  src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
  src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
  src/examples/disk_full_framework.cpp dfbdddae7f50d314e67db59300e5140b0476f807 
  src/examples/docker_no_executor_framework.cpp 0cbda07872fcf7db091c17ef49f5bcea6d80e660 
  src/examples/dynamic_reservation_framework.cpp e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f 
  src/examples/load_generator_framework.cpp 3ae25b221185ec6bd4bd84c478be9a511d763162 
  src/examples/long_lived_framework.cpp 0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
  src/examples/no_executor_framework.cpp dc75d7802e43164293c5d68ae78eb7fba6deba64 
  src/examples/persistent_volume_framework.cpp 43375503f1bdb74fba7994f73beb5b5486026e73 
  src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 
  src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c 
  src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
  src/examples/test_http_framework.cpp 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
  src/exec/exec.cpp 65a671d7ce83a51087d290ba039d18deba6313c2 
  src/executor/executor.cpp 5e95f999535a81bf6873144a83d520897b3cdc8a 
  src/files/files.cpp 8d896ed59e88de86149e00ba80806b61aba15c86 
  src/hdfs/hdfs.cpp 726925fbe2cbca1fbffb213eebb8de0cca815174 
  src/hook/manager.cpp 44c0c323fe696c8db8a7d1f57db5528723cfc9d9 
  src/launcher/default_executor.cpp 76c61068c7acdc7a2eaf59d6ba8308450925c72d 
  src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/linux/capabilities.cpp 694048cd0b9497681ea81a2d9405df967c4646f9 
  src/linux/cgroups.cpp 847f1167ec3920ff38cf29033f5fe9975bddc294 
  src/linux/fs.cpp fbd03b19abb9b56dbf3fb8a84d09a39171bbc1b0 
  src/linux/perf.cpp f5ac21df3c2dbaeac0b72444d6e6ef4b3bfe78ca 
  src/linux/systemd.cpp 2444ff4e432e61071c62e8e1ee94d62ac6b96c88 
  src/local/main.cpp 4d9be693a0cef447b619977aacb8997e1c882e6b 
  src/log/replica.cpp bb5aa8c7b4df6b6e4f5422a5cbc49d5f7b7d6878 
  src/log/tool/benchmark.cpp 9c7ca67fbaae9a967569a466083cf338fbcdad1c 
  src/log/tool/initialize.cpp 56b12b0d42a69f18bff37cb8fd9a31464a7038ad 
  src/log/tool/read.cpp e02a6e31c5ba41bee98e42711a1b7e70b720f79d 
  src/log/tool/replica.cpp 6c7183c4ed6010b243f7d29b87bf683536c7a302 
  src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 
  src/master/detector/zookeeper.cpp 09ae47c6c3851c6179963bcf7e4f73fcd77a826a 
  src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
  src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
  src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18 
  src/master/quota_handler.cpp 21bafd0064e9397f88185eaf687a58f85da94e2c 
  src/master/registrar.cpp cc1912683cc9a3dee0e84dd085c556b7c90b39bb 
  src/master/validation.cpp 798fc7975cf0f0b8b029a33137faa1737d47df66 
  src/master/weights_handler.cpp 1053652804a8fc6af31a3b8a9f632f836c897fa9 
  src/module/manager.cpp 75f70a7a62ea05d83c8378e23c7a5a719e92ecc4 
  src/oci/spec.cpp 273961edab7130fea13787acbc325bd6098d66bc 
  src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55 
  src/resource_provider/http_connection.hpp 05863aa9871d73c34993901017f53eb0f22e7886 
  src/resource_provider/manager.cpp aff1ca52186dceb9d85d17f6699e9760b497cd55 
  src/resource_provider/storage/disk_profile_adaptor.cpp 7c3aa1614e995889c8587867e8c40483641216d4 
  src/resource_provider/storage/disk_profile_utils.cpp 82c69d8b916a933f13e1185ffbf8ec65afd04ccf 
  src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 
  src/resource_provider/storage/uri_disk_profile_adaptor.hpp 0484933b42d0bd66c689b06cb48f492eef7bc606 
  src/sched/sched.cpp baa6b0c7307b2b72f7b1bc0acafd6e1c34d3029f 
  src/scheduler/scheduler.cpp 238f86928c609838e5acf077ac4134c2815c98c3 
  src/secret/resolver.cpp 13d45d056fa3e1a80e9f2d4ed9fbad274d0b0b78 
  src/slave/container_logger.cpp 3f4fa945aa0a837e08d9039390f22ee510d925f5 
  src/slave/container_loggers/lib_logrotate.hpp 303511cb6d8f4edfb99fd8206fb1a9fe5e7e5888 
  src/slave/container_loggers/lib_logrotate.cpp f0a59d05c00f1a8ad7a67f8fa837195a3502143f 
  src/slave/container_loggers/logrotate.hpp c6dbd61a5083dbb5c52bfb514ea7979a7a51158b 
  src/slave/container_loggers/logrotate.cpp bd41912fdf9faa70957a768ea5541e60824864ba 
  src/slave/containerizer/containerizer.cpp 59f107af1c08877dedd0597d0f60123940927ab0 
  src/slave/containerizer/docker.cpp 725cdb5df600b168fcee3ac9284c0c17bc7b313f 
  src/slave/containerizer/fetcher.cpp 7de57c21c55bc145a78d401bb4224322501c040b 
  src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/io/switchboard.cpp d0f98adf324744a6ffb7ff9cfac5e6909d3a64eb 
  src/slave/containerizer/mesos/io/switchboard_main.cpp 7e8e844a68c6a8d29008ff96f466e0bde704da98 
  src/slave/containerizer/mesos/isolators/appc/runtime.cpp e8ecd668ed14f4cfe190662e7a2a1d43be7d0c8a 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 6d663a5770418b7ffe2b3af50b9181ecde183c67 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp dc6c7aa1c998c30c8b17db04a38e7a1e28a6a6c1 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 321671f18b72edec1f8ed00f0069b539a698c4af 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuacct.cpp e0ee2f3c82c97a8f2638cc8c94855645aed1aa25 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 5d44b14ef2604e81f1e6d80c5d4aaa6b240cdee0 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 33dd6d98b3cb7fe70a94cdecdd89a136d494b869 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp ec2ce67e54387f26aa11c00d4c7f85f0807a127b 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 53d00082dae4980426294f0f4be210e53c7c8b48 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 929b7e0b7e459792c66ff6ba567f114987ca91e2 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp fd86ad13ce6706e2fbc67973cc897729ee18b6f3 
  src/slave/containerizer/mesos/isolators/environment_secret.cpp 77c1ba548ca47be0a7fbb55e141962a1b5a4842c 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 284432753dcc834d9a12d9505b3de1acd282bc7b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 9ac41af88abb8e95ee0710204c17e2468c2dc7f6 
  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 5b481b5e8e66104b8b7af6fa97dcb411fb0a1f5e 
  src/slave/containerizer/mesos/isolators/gpu/allocator.cpp c288ad634b856702483b9751f41445308babd0c9 
  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp f5e8860cc3ce3dcd6d4d15ccfd1cc690484b1b57 
  src/slave/containerizer/mesos/isolators/gpu/nvml.cpp 48a5bf6720e5c9a9ceec24740d47c14f0ad097b7 
  src/slave/containerizer/mesos/isolators/gpu/volume.cpp 0d0d778d6a8467c1ac87286e75d47faf8243afa4 
  src/slave/containerizer/mesos/isolators/linux/capabilities.cpp 2e8ad930df489777845928fb24239365c043f618 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 6905cd65e09f5b4f5a9c7663b2a47d9862cff467 
  src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283 
  src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp f8d38c6f6694e9eb9dc3f4f600b6a1976dd9c66a 
  src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp c40b57f78193520f9f0b901201b5c4c855cde8b3 
  src/slave/containerizer/mesos/isolators/network/cni/spec.hpp faa37bafe3dfe906708baa399ffb76d791abd75e 
  src/slave/containerizer/mesos/isolators/network/cni/spec.cpp ed5523e7ea7393094ef27f3a47c198a532c16c66 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp a3bb74665192f476a35837eb0a32d105c5ebc409 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 631553e2f61a1b95dd93d333b547ff237f65f59e 
  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp e0cae1036e2e49b4f61705c77f31ae166d1b1380 
  src/slave/containerizer/mesos/isolators/volume/secret.cpp 8071e4ee808bc825b13a6291767778d6ce3c2746 
  src/slave/containerizer/mesos/launch.cpp f25d90651ef32495c9161c3eaed8a327d1b2b926 
  src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada 
  src/slave/containerizer/mesos/paths.cpp cf7d47bf501f6401183c0026cf1aca98395351a0 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp 0daa4831c312b7c7a1083810a4a75f97dfed888b 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp f5e90527e6ace45a7745ca1ba1a9eeef938d2a68 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp f30c166f7b7b1d9a2d5d13a2da534d84a18a5c1c 
  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c2cdd9310e84c94e48f2e72de96ddced5b3d2e41 
  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 6ad97f98ceb8ceae50d786bfbbf49fd0eebc5c21 
  src/slave/containerizer/mesos/provisioner/backends/copy.cpp c48e93f7fd60e61908195d687fecb25fb10b9830 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp e32b9918ac15122477e05ebe701c9425bbefa809 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 5ce49ac396b03e8b6d87601ecaa0691d88de21e3 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 98c8fc769f2525c66539f08e2aa82506912e8a59 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp d7d8987d493a37d20f32ddd254dc0c3b15159951 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 693e8415b3cf791f26b8f7175df5c9a36dd4c234 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 8b3f07f5027cb90d4b4ed401960494709d3eda5f 
  src/slave/containerizer/mesos/provisioner/paths.cpp 80486c588979f5eeb2703c03055d98c53539631b 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp b3ed4fff9f85cec877b87b250505f5b43a82cfff 
  src/slave/containerizer/mesos/provisioner/store.cpp 11fce0eb47e9e6dfce6289afe04a1d58a0c4461a 
  src/slave/containerizer/mesos/provisioner/utils.cpp 6d24ce69678923de967e652e287e6ae9c98827de 
  src/slave/containerizer/mesos/utils.cpp 30e76d1d91651975033078f5450e45f5f2fd8ba0 
  src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106 
  src/slave/http.cpp 9e4525b321a74ca788a41e88f9f54fd5f4fb18eb 
  src/slave/main.cpp ca356687b2d38ea2dca53d3643a4be9471a857d8 
  src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 
  src/slave/qos_controller.cpp deb6d231a256ccb5eda0e5375c132930e5f56db2 
  src/slave/qos_controllers/load.cpp fa10ecae705f25ebf571961c3db127085545f546 
  src/slave/resource_estimator.cpp 3fea1c9196b87bbda6eb884bb2228c61c9c27123 
  src/slave/slave.cpp 1f77bccd95a05b9f2fb6bd7f0d273ba5dba1fade 
  src/slave/state.hpp 003211e4670c1092acb1634220d76bafd39e3a20 
  src/slave/state.cpp e7cf84993c74cf6da7fe22d5112e86e039780287 
  src/slave/task_status_update_manager.cpp f0cc5023e434fe889b9004a957860490b1bf1e83 
  src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
  src/state/log.cpp 1b2d727d23610d1c953ad0889ef37928d6de8d80 
  src/state/zookeeper.cpp 7a25e5e697400902d20197de985375f0eb7551d7 
  src/status_update_manager/status_update_manager_process.hpp 4a8d0509252d98ca41ab8982447f58a415cf7314 
  src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 
  src/tests/cluster.cpp b56212f6529a4d307e65797ad9bb34f2104fc832 
  src/tests/common/command_utils_tests.cpp 4a1cfd4ae2e07ea62e3a9fb3d2ec4e2ea2d5ab57 
  src/tests/containerizer/cni_isolator_tests.cpp b58a9caca136cfa42689159389bfdcb3f92f05ee 
  src/tests/containerizer/docker_archive.hpp 56211f7243816ae2342c7c0d6d974c7fca3fb5a2 
  src/tests/containerizer/docker_volume_isolator_tests.cpp 36fffe2ca7692ed11581e46a5035769db556a793 
  src/tests/containerizer/isolator_tests.cpp bdc3619f18cd65f609d967a036be0467c1e62896 
  src/tests/containerizer/memory_test_helper.cpp 53dc6a0ceb0a773a883b43e754c7229347d895fb 
  src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d 
  src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5 
  src/tests/disk_profile_adaptor_tests.cpp 4485f1635f484ce6e1c7c532eedb277f5eee118b 
  src/tests/environment.cpp a30592ac6b0002dad0947086ecbfdf4e2db62da5 
  src/tests/main.cpp e5ef73d564cdb4a5a7154df78dc565e15bdc5aef 
  src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd 
  src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 
  src/tests/script.cpp 2e50861bf40ceeaf6a40476a742e6e82c23ba86f 
  src/tests/slave_authorization_tests.cpp ea391f1d541a42b73c4e91f27b99b79a6908150d 
  src/tests/slave_tests.cpp 65d860594572b58a50a89358e31e97fd2a10bf08 
  src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
  src/tests/utils.cpp 06d3d6214b0e3d8c3902191b7aeb477467300c6a 
  src/uri/fetchers/copy.cpp 4f482ccc7792f8716ec5d54c4cda7357ec3cf6df 
  src/uri/fetchers/curl.cpp 51ac244ac7359d2dab6f8885dc6ba9c7f5a9433c 
  src/uri/fetchers/docker.cpp 94bbdee3a396ba7a14de609241b78b1579371738 
  src/uri/fetchers/hadoop.cpp 1c861e88a88e066436774cbd2c0575ffd7de4dd0 
  src/usage/main.cpp 64139f4a46de28ab1f925d3f0cd55b79fa409999 
  src/usage/usage.cpp 8414ac2bf700586495022fa58af3567b65f40190 
  src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8 
  src/zookeeper/detector.cpp 71ab101ee4637248c41229b10830a48580d7f2bd 
  src/zookeeper/group.cpp 6ba08d8f95f7a746e330d1f43aa1e8dfcc975638 
  src/zookeeper/zookeeper.cpp 52c4af192ccd1361afc4f7a0041889238c01e674 


Diff: https://reviews.apache.org/r/67169/diff/1/


Testing
-------


Thanks,

Benjamin Bannier