You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/09/22 15:46:28 UTC

[jira] [Commented] (ZOOKEEPER-1200) Remove obsolete DataTreeBuilder

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112577#comment-13112577 ] 

jiraposter@reviews.apache.org commented on ZOOKEEPER-1200:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2016/
-----------------------------------------------------------

Review request for zookeeper.


Summary
-------

There's a DataTreeBuilder thing in the whole type hierarchy of ZooKeeperServer classes, which is never used.


This addresses bug ZOOKEEPER-1200.
    https://issues.apache.org/jira/browse/ZOOKEEPER-1200


Diffs
-----

  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 9ccaa0e 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java d1ce278 
  src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 95c77b5 
  src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 976726e 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 68caa31 
  src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 60b78d7 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java e2e24aa 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 32096a7 
  src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 3cbfcaa 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java e37cbec 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java a6a86d0 

Diff: https://reviews.apache.org/r/2016/diff


Testing
-------


Thanks,

Thomas



> Remove obsolete DataTreeBuilder
> -------------------------------
>
>                 Key: ZOOKEEPER-1200
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1200
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-1200.patch
>
>
> There's a DataTreeBuilder thing in the whole type hierarchy of ZooKeeperServer classes, which is never used.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira