You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/08 09:08:02 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #21386: Adjust sharding sql federation decider logic when execute cross join with pagination
strongduanmu opened a new pull request, #21386:
URL: https://github.com/apache/shardingsphere/pull/21386
Fixes #21384.
Changes proposed in this pull request:
- adjust sharding sql federation decider logic when execute cross join with pagination
- add unit test and integration test
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #21386: Adjust sharding sql federation decider logic when execute cross join with pagination
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #21386:
URL: https://github.com/apache/shardingsphere/pull/21386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21386: Adjust sharding sql federation decider logic when execute cross join with pagination
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21386:
URL: https://github.com/apache/shardingsphere/pull/21386#issuecomment-1272282875
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21386](https://codecov.io/gh/apache/shardingsphere/pull/21386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c668278) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8224e757dd081d8787864d25d22e7c4197975961?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8224e75) will **increase** coverage by `0.01%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #21386 +/- ##
============================================
+ Coverage 61.56% 61.58% +0.01%
Complexity 2507 2507
============================================
Files 4089 4089
Lines 56609 56609
Branches 7487 7487
============================================
+ Hits 34853 34860 +7
+ Misses 18838 18833 -5
+ Partials 2918 2916 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sharding/decider/ShardingSQLFederationDecider.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZGVjaWRlci9TaGFyZGluZ1NRTEZlZGVyYXRpb25EZWNpZGVyLmphdmE=) | `76.92% <0.00%> (ø)` | |
| [...line/core/api/impl/AbstractPipelineJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL0Fic3RyYWN0UGlwZWxpbmVKb2JBUElJbXBsLmphdmE=) | `0.00% <ø> (ø)` | |
| [...o/consistencycheck/ConsistencyCheckJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9jb25zaXN0ZW5jeWNoZWNrL0NvbnNpc3RlbmN5Q2hlY2tKb2JBUElJbXBsLmphdmE=) | `0.00% <ø> (ø)` | |
| [...peline/scenario/migration/MigrationJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9taWdyYXRpb24vTWlncmF0aW9uSm9iQVBJSW1wbC5qYXZh) | `0.00% <ø> (ø)` | |
| [...yaml/job/YamlConsistencyCheckJobConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS95YW1sL2pvYi9ZYW1sQ29uc2lzdGVuY3lDaGVja0pvYkNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
| [...peline/yaml/job/YamlMigrationJobConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS95YW1sL2pvYi9ZYW1sTWlncmF0aW9uSm9iQ29uZmlndXJhdGlvbi5qYXZh) | `23.07% <ø> (ø)` | |
| [...yaml/job/YamlMigrationJobConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS95YW1sL2pvYi9ZYW1sTWlncmF0aW9uSm9iQ29uZmlndXJhdGlvblN3YXBwZXIuamF2YQ==) | `35.71% <ø> (ø)` | |
| [...ml/metadata/YamlPipelineColumnMetaDataSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS95YW1sL21ldGFkYXRhL1lhbWxQaXBlbGluZUNvbHVtbk1ldGFEYXRhU3dhcHBlci5qYXZh) | `12.50% <ø> (ø)` | |
| [...ion/advanced/resultset/SQLFederationResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC1mZWRlcmF0aW9uL2V4ZWN1dG9yL2FkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3Jlc3VsdHNldC9TUUxGZWRlcmF0aW9uUmVzdWx0U2V0LmphdmE=) | `80.18% <0.00%> (ø)` | |
| [.../select/projection/impl/AggregationProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL0FnZ3JlZ2F0aW9uUHJvamVjdGlvbi5qYXZh) | `100.00% <100.00%> (+50.00%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/shardingsphere/pull/21386/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org