You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2026/08/20 06:41:31 UTC
[PR] Fix flaky pipeline progress persist test [shardingsphere]
sandynz opened a new pull request, #39527:
URL: https://github.com/apache/shardingsphere/pull/39527
Changes proposed in this pull request:
- Fix flaky pipeline progress persist test
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [ ] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky pipeline progress persist test [shardingsphere]
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #39527:
URL: https://github.com/apache/shardingsphere/pull/39527#issuecomment-5352372054
### Result
**Review Result: Mergeable**
The squashed commit fixes the concurrent static-mock race without leaving duplicate or misleading tests.
### Evidence
- The first exception is established before the method-scoped `ThreadLocalRandom` static mock.
- The mock now covers only the two subsequent exception-throttling calls.
- The focused exception test passed 10/10.
- The complete test class passed 8/8.
- IDE inspection, scoped Spotless, and module Checkstyle passed.
### Coverage
- Reviewed head: `f3c8e5fbaeaeb7fe0aa950a5a70dce33ea6262ec`
- Reviewed range: `a523db925f427deff69a9e9b85c4b4ce40933a1a..f3c8e5fbaeaeb7fe0aa950a5a70dce33ea6262ec`
- Authoritative scope: one modified test file.
- Behavior clusters: scheduled exception logging, thread-scoped static mocking, and success-test consolidation.
- Phase A: all checks passed.
- Phase B: no significant issues; completeness, correctness, and coherence were verified.
- Root-cause, blast-radius/contracts, tests/runtime, adversarial, and convergence passes completed.
- No unresolved evidence gaps or expert-review requirements remain.
- This is a code-scope result; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky pipeline progress persist test [shardingsphere]
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #39527:
URL: https://github.com/apache/shardingsphere/pull/39527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org