You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by ericklaus-wf <gi...@git.apache.org> on 2015/12/21 21:30:44 UTC
[GitHub] thrift pull request: Accept generator option "package_prefix"
GitHub user ericklaus-wf opened a pull request:
https://github.com/apache/thrift/pull/755
Accept generator option "package_prefix"
Permit prefixing import paths with a certain string to support devs who will place the generated code below the top level of their python hierarchy.
This is similar to the go generator's package_prefix generator option.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericklaus-wf/thrift py-package-prefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #755
----
commit a84f7d2956caf5cb75730ae49b9c051eee8ced9e
Author: Eric Klaus <er...@workiva.com>
Date: 2015-12-15T15:55:05Z
Accept generator option "package_prefix"
Permit prefixing import paths with a certain string to support devs who will place the generated code below the top level of their python hierarchy.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...
Posted by ericklaus-wf <gi...@git.apache.org>.
Github user ericklaus-wf closed the pull request at:
https://github.com/apache/thrift/pull/755
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...
Posted by ericklaus-wf <gi...@git.apache.org>.
GitHub user ericklaus-wf reopened a pull request:
https://github.com/apache/thrift/pull/755
THRIFT-3499: Add package_prefix to python generator
Permit prefixing import paths with a certain string to support devs who will place the generated code below the top level of their python hierarchy.
This is similar to the go generator's package_prefix generator option.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericklaus-wf/thrift py-package-prefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #755
----
commit a84f7d2956caf5cb75730ae49b9c051eee8ced9e
Author: Eric Klaus <er...@workiva.com>
Date: 2015-12-15T15:55:05Z
Accept generator option "package_prefix"
Permit prefixing import paths with a certain string to support devs who will place the generated code below the top level of their python hierarchy.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...
Posted by ericklaus-wf <gi...@git.apache.org>.
Github user ericklaus-wf closed the pull request at:
https://github.com/apache/thrift/pull/755
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...
Posted by ericklaus-wf <gi...@git.apache.org>.
GitHub user ericklaus-wf reopened a pull request:
https://github.com/apache/thrift/pull/755
THRIFT-3499: Add package_prefix to python generator
Permit prefixing import paths with a certain string to support devs who will place the generated code below the top level of their python hierarchy.
This is similar to the go generator's package_prefix generator option.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericklaus-wf/thrift py-package-prefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #755
----
commit a84f7d2956caf5cb75730ae49b9c051eee8ced9e
Author: Eric Klaus <er...@workiva.com>
Date: 2015-12-15T15:55:05Z
Accept generator option "package_prefix"
Permit prefixing import paths with a certain string to support devs who will place the generated code below the top level of their python hierarchy.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...
Posted by ericklaus-wf <gi...@git.apache.org>.
Github user ericklaus-wf commented on the pull request:
https://github.com/apache/thrift/pull/755#issuecomment-166932712
The CI build has failed when running the cpp-cpp test twice now. I'm not sure how my python changes could affect this. Am I kicking off the CI incorrectly?
Relevant CI failure line is below:
```
cpp-cpp compact http-ip timeout(128)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...
Posted by ericklaus-wf <gi...@git.apache.org>.
Github user ericklaus-wf commented on the pull request:
https://github.com/apache/thrift/pull/755#issuecomment-170096390
@Jens-G Do I need to do anything else to get this PR moving?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/755
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/755#issuecomment-166950715
Not at all. Some cross tests are flaky and should be excluded, if not fixed immediately.
In your case the failure is clearly unrelated so no need to re-invoke any more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---