You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/12/08 22:10:00 UTC
Re: Review Request 53238: Changed agent to report "retired" agent IDs
on registration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53238/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 10:10 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Address review comments.
Bugs: MESOS-5396
https://issues.apache.org/jira/browse/MESOS-5396
Repository: mesos
Description
-------
If the agent observes that the boot ID has changed since the last time
it successfully (re-)registered with the master, we know that any agent
IDs that were previously in use in this `work_dir` must be associated
with different boot IDs; hence, any executors/tasks associated with
those agent IDs are no longer running, and those agent ID will never
attempt to re-register with the master. The agent now reports these
retired agent IDs to the master; the master will later take advantage of
this information, e.g., to learn that an agent that we think might
re-register after master failover will never re-register.
Diffs (updated)
-----
src/messages/messages.proto 7cbac56099689ffc378d83bae3a16abb49b50dd9
src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
src/slave/slave.cpp c54d33565dd0c1cf50dba2fbb134a6e546ce8614
src/slave/state.hpp a1c849690a5c2b3fc5ea3eb2e782e99a2b0f8044
src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8
Diff: https://reviews.apache.org/r/53238/diff/
Testing
-------
`make check`
Thanks,
Neil Conway