[GitHub] [activemq-website] gemmellr commented on a change in pull request #58: [AMQ-8278] Add a dynamic news feed section to home page

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #58:
URL: https://github.com/apache/activemq-website/pull/58#discussion_r697366635



##########
File path: src/_includes/news.md
##########
@@ -0,0 +1,27 @@
+{% assign releases = site.documents %}
+{% assign releases = releases | sort: "release_date" | reverse %}
+
+    <h3>Recent Releases</h3>
+    <div class="row align-middle">
+
+{% for release in releases %}
+    <div class="col-lg-4 col-md-auto">
+        <div class="card card-orange">
+            <div class="card-body">
+                {% if release.collection contains "artemis" %}
+                    <h5 class="card-title text-blue">Artemis {{release.version}} Release</h5>
+                    <a style="margin-top: 10px" href="/components/artemis/download/release-notes-{{release.version}}" class="btn btn-secondary float-right">Release<i class="fa-download fa btn-icon"></i></a>
+                {% else %}
+                    <h5 class="card-title text-blue">{{release.title}}</h5>
+                    <a style="margin-top: 10px" href="{{release.url}}" class="btn btn-secondary float-right">Release<i class="fa-download fa btn-icon"></i></a>

Review comment:
       Seems like a bit of a disparity here with the 5.x "Release" download-button looking to go to its specific release page, while the Artemis "Release" download-button goes to its release notes. The Artemis one should just go to the main download page.
   
   (obviously that only works with my single-entry-per-stream comment...if not that doing that, then this would need to check for 'current-release' status and instead go to the past-releases page if not)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org