You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/03 11:42:24 UTC

[GitHub] [incubator-echarts] dvago opened a new issue #12748: MarkPoint not considering backgroundColour, borderColor and borderWidth attributes

dvago opened a new issue #12748:
URL: https://github.com/apache/incubator-echarts/issues/12748


   ### Version
   4.8.0
   
   ### Steps to reproduce
   I'm importing those files along with the main echarts library (using vue-echarts)
   
   ```
   import 'echarts/lib/component/tooltip'
   import 'echarts/lib/component/title'
   import 'echarts/lib/chart/line'
   import 'echarts/lib/component/markLine'
   import 'echarts/lib/component/markPoint'
   import 'echarts/lib/component/dataZoom'
   import 'zrender/lib/svg/svg'
   
   ```
   
   Then in my configuration I set:
   
   ```
   markPoint: {
                   data: [
                       {type: 'max', name: 'Max'},
                       {type: 'min', name: 'Min'}
                   ],
                   label: {
                       show: true,
                       fontSize: 11,
                       position: 'right',
                       formatter: '{b}\n{c}',
                       backgroundColor: '#DDDDDD',
                       borderColor: 'red',
                       borderWidth: 1,
                       padding: [2,2,2,2]
                   }
               },
   ```
   
   ### What is expected?
   I expect to see a background colour and a border on the Min and Max markpoint labels
   
   ### What is actually happening?
   these 3 attributes gets completely ignored, however the rest of the configuration works (e.g. padding)
   
   ---
   I believe is due to some missing script from the import list as I tried to reproduce the issue on the example page: https://echarts.apache.org/examples/en/editor.html?c=line-marker and it does work as expected.
   
   Thanks in advance for your support.
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] Ovilia commented on issue #12748: MarkPoint not considering backgroundColour, borderColor and borderWidth attributes

Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #12748:
URL: https://github.com/apache/incubator-echarts/issues/12748#issuecomment-640327727


   Generally speaking, you should use `import * as echarts from 'echarts'` instead and without considering which packages to include.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] dvago commented on issue #12748: MarkPoint not considering backgroundColour, borderColor and borderWidth attributes

Posted by GitBox <gi...@apache.org>.
dvago commented on issue #12748:
URL: https://github.com/apache/incubator-echarts/issues/12748#issuecomment-640438963


   `import * as` means you decide to import the whole library, which for production environments is quite inefficient as you might use one or two type of charts and one specific tool. 
   
   I would rather prefer to have a list of specific modules required for specific features in order to decide what to import and what not to import, hope that approach makes sense to you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org