You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/12 08:02:37 UTC
[GitHub] [apisix-dashboard] membphis opened a new pull request #1037: docs: update CHANGELOG for v2.2
membphis opened a new pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#issuecomment-743721219
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=h1) Report
> Merging [#1037](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=desc) (6214852) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93b9c6820d361380b0c370a3946a350dbac10f2f?el=desc) (93b9c68) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1037 +/- ##
==========================================
- Coverage 40.13% 40.07% -0.07%
==========================================
Files 26 26
Lines 1572 1572
==========================================
- Hits 631 630 -1
- Misses 850 851 +1
Partials 91 91
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1037/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=footer). Last update [93b9c68...6214852](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#issuecomment-743721219
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=h1) Report
> Merging [#1037](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=desc) (6ac57aa) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93b9c6820d361380b0c370a3946a350dbac10f2f?el=desc) (93b9c68) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1037 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 26 26
Lines 1572 1572
=======================================
Hits 631 631
Misses 850 850
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=footer). Last update [93b9c68...6ac57aa](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#issuecomment-743721219
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=h1) Report
> Merging [#1037](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=desc) (44cede4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93b9c6820d361380b0c370a3946a350dbac10f2f?el=desc) (93b9c68) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1037 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 26 26
Lines 1572 1572
=======================================
Hits 631 631
Misses 850 850
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=footer). Last update [93b9c68...44cede4](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#issuecomment-743721219
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=h1) Report
> Merging [#1037](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=desc) (c852ff3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93b9c6820d361380b0c370a3946a350dbac10f2f?el=desc) (93b9c68) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1037 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 26 26
Lines 1572 1572
=======================================
Hits 631 631
Misses 850 850
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=footer). Last update [93b9c68...44cede4](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#discussion_r542054397
##########
File path: CHANGELOG.md
##########
@@ -19,18 +19,46 @@
# Table of Contents
+- [2.2.0](#220)
- [2.1.1](#211)
- [2.1.0](#210)
- [2.0.0](#200)
- [1.5.0](#150)
- [1.0.0](#100)
+# 2.2.0
Review comment:
I think this is OK now, we have been using it like this.
https://raw.githubusercontent.com/apache/apisix/master/CHANGELOG.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#discussion_r541932071
##########
File path: CHANGELOG.md
##########
@@ -19,18 +19,46 @@
# Table of Contents
+- [2.2.0](#220)
- [2.1.1](#211)
- [2.1.0](#210)
- [2.0.0](#200)
- [1.5.0](#150)
- [1.0.0](#100)
+# 2.2.0
Review comment:
Should we use `2.2` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#discussion_r541946637
##########
File path: CHANGELOG.md
##########
@@ -19,18 +19,46 @@
# Table of Contents
+- [2.2.0](#220)
- [2.1.1](#211)
- [2.1.0](#210)
- [2.0.0](#200)
- [1.5.0](#150)
- [1.0.0](#100)
+# 2.2.0
Review comment:
ok for me, cc @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#issuecomment-743721219
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=h1) Report
> Merging [#1037](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=desc) (28ea06f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93b9c6820d361380b0c370a3946a350dbac10f2f?el=desc) (93b9c68) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1037 +/- ##
==========================================
- Coverage 40.13% 40.07% -0.07%
==========================================
Files 26 26
Lines 1572 1572
==========================================
- Hits 631 630 -1
- Misses 850 851 +1
Partials 91 91
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1037/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=footer). Last update [93b9c68...28ea06f](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1037: docs: update CHANGELOG for v2.2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1037:
URL: https://github.com/apache/apisix-dashboard/pull/1037#issuecomment-743721219
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=h1) Report
> Merging [#1037](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=desc) (caae099) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93b9c6820d361380b0c370a3946a350dbac10f2f?el=desc) (93b9c68) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1037 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 26 26
Lines 1572 1572
=======================================
Hits 631 631
Misses 850 850
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=footer). Last update [93b9c68...caae099](https://codecov.io/gh/apache/apisix-dashboard/pull/1037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org