You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/04/05 22:55:15 UTC
Review Request 45776: GEODE-1177: Stop sizing an object at
InternalDistributedSystem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45776/
-----------------------------------------------------------
Review request for geode, Darrel Schneider and Sai Boorlagadda.
Repository: geode
Description
-------
This is not a complete fix for the http session management problem, but
this is a safety catch we should probably have in the product to avoid
following references into InternalDistributedSystem when computing the
size of a users object.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java d94487cbe39200ad937ffe7adc2d3b9e0ee6e81a
geode-core/src/test/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizerJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/45776/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 45776: GEODE-1177: Stop sizing an object at
InternalDistributedSystem
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45776/#review127606
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java (line 55)
<https://reviews.apache.org/r/45776/#comment190998>
Do you want to update this comment?
geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java (line 59)
<https://reviews.apache.org/r/45776/#comment190999>
Is a more complete solution possible instead of a list of special cases?
- Darrel Schneider
On April 6, 2016, 6:14 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45776/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 6:14 p.m.)
>
>
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is not a complete fix for the http session management problem, but
> this is a safety catch we should probably have in the product to avoid
> following references into InternalDistributedSystem when computing the
> size of a users object.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java d94487cbe39200ad937ffe7adc2d3b9e0ee6e81a
> geode-core/src/test/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizerJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45776/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 45776: GEODE-1177: Stop sizing an object at
InternalDistributedSystem
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45776/
-----------------------------------------------------------
(Updated April 7, 2016, 1:14 a.m.)
Review request for geode, Darrel Schneider and Sai Boorlagadda.
Changes
-------
I added a couple more classes to ignore in the sizer, based on the issues I had - we'll now stop sizing at Loggers or Classloaders.
Repository: geode
Description
-------
This is not a complete fix for the http session management problem, but
this is a safety catch we should probably have in the product to avoid
following references into InternalDistributedSystem when computing the
size of a users object.
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java d94487cbe39200ad937ffe7adc2d3b9e0ee6e81a
geode-core/src/test/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizerJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/45776/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 45776: GEODE-1177: Stop sizing an object at
InternalDistributedSystem
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45776/#review127216
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On April 5, 2016, 8:55 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45776/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 8:55 p.m.)
>
>
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is not a complete fix for the http session management problem, but
> this is a safety catch we should probably have in the product to avoid
> following references into InternalDistributedSystem when computing the
> size of a users object.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java d94487cbe39200ad937ffe7adc2d3b9e0ee6e81a
> geode-core/src/test/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizerJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45776/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 45776: GEODE-1177: Stop sizing an object at
InternalDistributedSystem
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45776/#review127214
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On April 5, 2016, 1:55 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45776/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 1:55 p.m.)
>
>
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is not a complete fix for the http session management problem, but
> this is a safety catch we should probably have in the product to avoid
> following references into InternalDistributedSystem when computing the
> size of a users object.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java d94487cbe39200ad937ffe7adc2d3b9e0ee6e81a
> geode-core/src/test/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizerJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45776/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>