[GitHub] [spark] itholic commented on a change in pull request #35203: [SPARK-37886][PYTHON][TESTS] Refactor on OpsTestCase and use ComparisonTestBase

[GitBox <gi...@apache.org>]

itholic commented on a change in pull request #35203:
URL: https://github.com/apache/spark/pull/35203#discussion_r785644649



##########
File path: python/pyspark/pandas/tests/data_type_ops/testing_utils.py
##########
@@ -41,7 +43,7 @@
     from pandas import BooleanDtype, StringDtype
 
 
-class TestCasesUtils:
+class OpsTestCase(ComparisonTestBase):
     """A utility holding common test cases for arithmetic operations of different data types."""

Review comment:
       Not a strong feeling about this, but how about rename this to `OpsTestCaseUtils` or refine the doc string ??
   
   Because it says `"A utility ..."` in the doc string, so it maybe could confusion for someone.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org