You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/17 09:35:12 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #33703: GH-14748:[C++] Modify some comments about shared_ptr's ownership in parquet-cpp.

pitrou commented on code in PR #33703:
URL: https://github.com/apache/arrow/pull/33703#discussion_r1071971871


##########
cpp/src/parquet/arrow/test_util.h:
##########
@@ -463,12 +463,16 @@ Status MakeEmptyListsArray(int64_t size, std::shared_ptr<Array>* out_array) {
   return Status::OK();
 }
 
+// Please make sure that the return value should have an object assigned explicitly
+// if you want to use the pointer contained.

Review Comment:
   I don't understand what this comment means, nor why you are adding it in multiple places. Would you like to explain?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org