You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2021/03/13 18:13:41 UTC
[GitHub] [fluo] ctubbsii opened a new pull request #1111: Update thrift to 0.14.1
ctubbsii opened a new pull request #1111:
URL: https://github.com/apache/fluo/pull/1111
* Bump libthrift dependency
* Regenerate thrift files
* Fix breakage because org.apache.thrift.transport.TFastFramedTransport
got moved to org.apache.thrift.transport.layered.TFastFramedTransport
* Also remove some unused imports
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo] ctubbsii commented on pull request #1111: Update thrift to 0.14.1
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1111:
URL: https://github.com/apache/fluo/pull/1111#issuecomment-798727979
This is low risk, because libthrift is shaded into Fluo, so there shouldn't be any conflicts with other versions of thrift from Accumulo or elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo] ctubbsii commented on pull request #1111: Update thrift to 0.14.1
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1111:
URL: https://github.com/apache/fluo/pull/1111#issuecomment-802043303
> The changes looks good. There were surprisingly few changes in the generated code. The build failed, I restarted to see if it will pass. Were you able to run a full build locally?
No. I'm not sure why it is failing. I thought maybe it had to do with Java 11 issues, but haven't had time to investigate. Fluo shades Thrift, so it shouldn't be a conflict with other dependencies, and the only API breakage was the relocation of TFastFramedTransport to a subpackage. All the tests seem to be hanging/timing out. I'm not sure why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org