You are viewing a plain text version of this content. The canonical link for it is here.
Posted to svn@forrest.apache.org by th...@apache.org on 2008/10/09 14:02:32 UTC

svn commit: r703147 - /forrest/trunk/main/fresh-site/forrest.properties.xml

Author: thorsten
Date: Thu Oct  9 05:02:32 2008
New Revision: 703147

URL: http://svn.apache.org/viewvc?rev=703147&view=rev
Log:
Removing extension property since it equal the default. No need to declare it\!

Modified:
    forrest/trunk/main/fresh-site/forrest.properties.xml

Modified: forrest/trunk/main/fresh-site/forrest.properties.xml
URL: http://svn.apache.org/viewvc/forrest/trunk/main/fresh-site/forrest.properties.xml?rev=703147&r1=703146&r2=703147&view=diff
==============================================================================
--- forrest/trunk/main/fresh-site/forrest.properties.xml (original)
+++ forrest/trunk/main/fresh-site/forrest.properties.xml Thu Oct  9 05:02:32 2008
@@ -22,7 +22,6 @@
     # You can configure the theme name and its extension here
     -->
   <property name="dispatcher.theme" value="pelt"/>
-  <property name="dispatcher.theme-ext" value=".fv"/>
 <!--SVG example for project/group logo-->
   <property name="group-name" value="group"/>
   <property name="project-name" value="project"/>



Re: default properties (Was: svn commit: r703147)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> David Crossley wrote:
> > > Author: thorsten
> > > Date: Thu Oct  9 05:02:32 2008
> > > New Revision: 703147
> > > 
> > > URL: http://svn.apache.org/viewvc?rev=703147&view=rev
> > > Log:
> > > Removing extension property since it equal the default. No need to declare it\!
> > 
> > We are declaring the defaults elsewhere in all the
> > properties files. 
> 
> I am not sure I understand you. 
> 
> The xml system follows exactly what we say in a forrest.properties of a
> plugin config.
> ##############
> # This is a minimal properties file.
> # These are defaults, un-comment them only if you need to change them.
> # See the full set of default properties in a 'forrest seed-sample'
> site.
> # Copy properties from there as needed.
> ##############
> 
> In case of the plugins the default properties are stored in
> $PLUGIN_HOME/default.plugin.properties.xml

Woops sorry, i see now that i was confused and
missed that default.plugin.properties.xml file.

-David

Re: default properties (Was: svn commit: r703147)

Posted by Brian M Dube <bd...@apache.org>.
On Fri, Oct 10, 2008 at 09:16:49AM +0200, Thorsten Scherler wrote:
> Hmm just notice that
> http://forrest.apache.org/module.properties.properties does not exist. 

Yes, this has been discussed [1] [2] as content that cannot be published.

Brian

[1] http://www.mail-archive.com/dev@forrest.apache.org/msg15129.html
[2] https://issues.apache.org/jira/browse/FOR-1117

Re: default properties (Was: svn commit: r703147)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Fri, 2008-10-10 at 10:13 +1100, David Crossley wrote:
> > Author: thorsten
> > Date: Thu Oct  9 05:02:32 2008
> > New Revision: 703147
> > 
> > URL: http://svn.apache.org/viewvc?rev=703147&view=rev
> > Log:
> > Removing extension property since it equal the default. No need to declare it\!
> 
> We are declaring the defaults elsewhere in all the
> properties files. 

I am not sure I understand you. 

The xml system follows exactly what we say in a forrest.properties of a
plugin config.
##############
# This is a minimal properties file.
# These are defaults, un-comment them only if you need to change them.
# See the full set of default properties in a 'forrest seed-sample'
site.
# Copy properties from there as needed.
##############

In case of the plugins the default properties are stored in
$PLUGIN_HOME/default.plugin.properties.xml

> Would it be better to be consistent?

You mean always minimal configuration and reference to a complete
overview of all properties.

> Where else are the available properties documented?

the dispatcher default:
http://forrest.apache.org/pluginDocs/plugins_0_80/org.apache.forrest.plugin.internal.dispatcher/int/index.html

the core/all aviable:
http://forrest.apache.org/docs_0_90/properties.html

Hmm just notice that
http://forrest.apache.org/module.properties.properties does not exist. 

However 
http://localhost:8888/module.properties.properties returns you a
complete list of all properties. 

We should add a paragraph (or two) about the default properties and how
to best override them (take only what you need)

salu2. 
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


default properties (Was: svn commit: r703147)

Posted by David Crossley <cr...@apache.org>.
> Author: thorsten
> Date: Thu Oct  9 05:02:32 2008
> New Revision: 703147
> 
> URL: http://svn.apache.org/viewvc?rev=703147&view=rev
> Log:
> Removing extension property since it equal the default. No need to declare it\!

We are declaring the defaults elsewhere in all the
properties files. Would it be better to be consistent?
Where else are the available properties documented?

-David

> Modified:
>     forrest/trunk/main/fresh-site/forrest.properties.xml
> 
> Modified: forrest/trunk/main/fresh-site/forrest.properties.xml
> URL: http://svn.apache.org/viewvc/forrest/trunk/main/fresh-site/forrest.properties.xml?rev=703147&r1=703146&r2=703147&view=diff
> ==============================================================================
> --- forrest/trunk/main/fresh-site/forrest.properties.xml (original)
> +++ forrest/trunk/main/fresh-site/forrest.properties.xml Thu Oct  9 05:02:32 2008
> @@ -22,7 +22,6 @@
>      # You can configure the theme name and its extension here
>      -->
>    <property name="dispatcher.theme" value="pelt"/>
> -  <property name="dispatcher.theme-ext" value=".fv"/>
>  <!--SVG example for project/group logo-->
>    <property name="group-name" value="group"/>
>    <property name="project-name" value="project"/>
> 
>