You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/12 07:18:56 UTC

[GitHub] [apisix] tzssangglass edited a comment on issue #1195: feature: support multiple ports like stream listen in http and https listen port.

tzssangglass edited a comment on issue #1195:
URL: https://github.com/apache/apisix/issues/1195#issuecomment-706926109


   > Apache APISIX is now using style 1, I think it should be consistent, this is also a more common way in yaml
   
   In master branch，`node_listen` is not  using style 1，https://github.com/apache/apisix/blob/b8e4b8589d3b62a1c30fe726963a9dca7a6ff3f6/conf/config-default.yaml#L22-L23
   
   but `stream_proxy`  is using style 1，
   https://github.com/apache/apisix/blob/b8e4b8589d3b62a1c30fe726963a9dca7a6ff3f6/conf/config-default.yaml#L88-L90
   
   so without considering backward compatibility，`node_listen` change to style 1 is the most suitable.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org