[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #636: NimBLE/host: `ble_gap_unpair` should continue un-pairing after connection termination

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #636: NimBLE/host: `ble_gap_unpair` should continue un-pairing after connection termination
URL: https://github.com/apache/mynewt-nimble/pull/636#discussion_r343939875
 
 

 ##########
 File path: nimble/host/src/ble_hs_pvcy.c
 ##########
 @@ -64,6 +64,12 @@ ble_hs_pvcy_remove_entry(uint8_t addr_type, const uint8_t *addr)
 {
     struct ble_hci_le_rmv_resolve_list_cp cmd;
 
+    /* First check if privacy started flag is enabled, no point in going
+     * further if pvcy_started is not enabled */
+    if (!ble_hs_pvcy_started) {
 
 Review comment:
   ble_hs_prvcy_started  means only that rpa timeout has been set in the controller and Controller will keep generating local RPA.
   If timeout is disabled we can still use resolving list.
   It is usually a case when NImble use public address but still wants to use resolving list.
   
   Therefore I believe that this change will actually break Nimble when it not uses RPA.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services