You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by yo...@apache.org on 2022/08/20 04:02:22 UTC
[bookkeeper] branch master updated: bugfix for .asf.yaml (#3451)
This is an automated email from the ASF dual-hosted git repository.
yong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new d9bcc8bde2 bugfix for .asf.yaml (#3451)
d9bcc8bde2 is described below
commit d9bcc8bde2690e5b5d3a97488d658e0a5cbae884
Author: StevenLuMT <42...@users.noreply.github.com>
AuthorDate: Sat Aug 20 12:02:16 2022 +0800
bugfix for .asf.yaml (#3451)
Descriptions of the changes in this PR:
### Motivation
using [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection) to configure the project,
but there 's some config bugfix for project's .asf.yaml
the name of workflow's jobs is not set, so #3439 causes contexts can't match check's jobs
this picture is the other new add pr's running result: the other pr's workflow run abnormally
<img width="923" alt="image" src="https://user-images.githubusercontent.com/42990025/185718866-b7054dd7-502f-4371-8906-c43f8b1b166b.png">
this picture is current running result: current pr is running normally because the job name is added in yaml file
<img width="954" alt="image" src="https://user-images.githubusercontent.com/42990025/185718710-ec41584e-4871-40cc-9ed6-655caa7ff021.png">
### Changes
1. add the name for checks
2. change required_approving_review_count to 2 person
3. update README.md for workflows
---
.asf.yaml | 2 +-
.github/workflows/README.md | 2 +-
.github/workflows/backward-compat-tests.yml | 2 +-
.github/workflows/bookie-tests.yml | 2 +-
.github/workflows/bot.yml | 1 +
.github/workflows/client-tests.yml | 2 +-
.github/workflows/compatibility-check-java11.yml | 2 +-
.github/workflows/compatibility-check-java17.yml | 2 +-
.github/workflows/compatibility-check-java8.yml | 2 +-
.github/workflows/dead-link-checker.yaml | 1 +
.github/workflows/integration-tests.yml | 2 +-
.github/workflows/macos-build.yml | 1 +
.github/workflows/owasp-dep-check.yml | 2 +-
.github/workflows/pr-validation.yml | 2 +-
.github/workflows/remaining-tests.yml | 2 +-
.github/workflows/replication-tests.yml | 2 +-
.github/workflows/stream-tests.yml | 2 +-
.github/workflows/tls-tests.yml | 2 +-
.github/workflows/windows-build.yml | 1 +
19 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/.asf.yaml b/.asf.yaml
index 91f5cd4a7a..813533104e 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -63,7 +63,7 @@ github:
required_pull_request_reviews:
dismiss_stale_reviews: false
require_code_owner_reviews: true
- required_approving_review_count: 1
+ required_approving_review_count: 2
# squash or rebase must be allowed in the repo for this setting to be set to true.
required_linear_history: true
diff --git a/.github/workflows/README.md b/.github/workflows/README.md
index f007cc3e18..b0c71c6def 100644
--- a/.github/workflows/README.md
+++ b/.github/workflows/README.md
@@ -44,7 +44,7 @@ following command will print out the names of each file and the associated with
the context will be named by the `id`.
```shell
-for f in .github/workflows/*.yaml; \
+for f in .github/workflows/*.yaml .github/workflows/*.yml; \
do FILE=$f yq eval -o j '.jobs | to_entries | {"file": env(FILE),"id":.[].key, "name":.[].value.name}' $f; \
done
```
diff --git a/.github/workflows/backward-compat-tests.yml b/.github/workflows/backward-compat-tests.yml
index a1cca5f8eb..f63923477c 100644
--- a/.github/workflows/backward-compat-tests.yml
+++ b/.github/workflows/backward-compat-tests.yml
@@ -34,7 +34,7 @@ env:
jobs:
test:
-
+ name: Backward compatibility tests
runs-on: ubuntu-latest
timeout-minutes: 120
steps:
diff --git a/.github/workflows/bookie-tests.yml b/.github/workflows/bookie-tests.yml
index 655e179fd2..460fe6377c 100644
--- a/.github/workflows/bookie-tests.yml
+++ b/.github/workflows/bookie-tests.yml
@@ -34,7 +34,7 @@ env:
jobs:
test:
-
+ name: Bookie Tests
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/bot.yml b/.github/workflows/bot.yml
index d1eb093c56..b29d767c70 100644
--- a/.github/workflows/bot.yml
+++ b/.github/workflows/bot.yml
@@ -24,6 +24,7 @@ on:
jobs:
bot:
+ name: Bot tests
runs-on: ubuntu-latest
steps:
diff --git a/.github/workflows/client-tests.yml b/.github/workflows/client-tests.yml
index 7638865787..e63ad25294 100644
--- a/.github/workflows/client-tests.yml
+++ b/.github/workflows/client-tests.yml
@@ -34,7 +34,7 @@ env:
jobs:
test:
-
+ name: Client Tests
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/compatibility-check-java11.yml b/.github/workflows/compatibility-check-java11.yml
index b0dd8a1123..ac0b2b3c53 100644
--- a/.github/workflows/compatibility-check-java11.yml
+++ b/.github/workflows/compatibility-check-java11.yml
@@ -34,7 +34,7 @@ env:
jobs:
check:
-
+ name: Compatibility Check Java11
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/compatibility-check-java17.yml b/.github/workflows/compatibility-check-java17.yml
index 79bd80c3f1..1f29476658 100644
--- a/.github/workflows/compatibility-check-java17.yml
+++ b/.github/workflows/compatibility-check-java17.yml
@@ -33,7 +33,7 @@ env:
jobs:
check:
-
+ name: Compatibility Check Java17
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/compatibility-check-java8.yml b/.github/workflows/compatibility-check-java8.yml
index 6da9a21902..0785c6293d 100644
--- a/.github/workflows/compatibility-check-java8.yml
+++ b/.github/workflows/compatibility-check-java8.yml
@@ -34,7 +34,7 @@ env:
jobs:
check:
-
+ name: Compatibility Check Java8
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/dead-link-checker.yaml b/.github/workflows/dead-link-checker.yaml
index f20dd0073c..8b7c564df4 100644
--- a/.github/workflows/dead-link-checker.yaml
+++ b/.github/workflows/dead-link-checker.yaml
@@ -31,6 +31,7 @@ concurrency:
jobs:
check-dead-links:
+ name: Dead link checker
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
index 4c7f211613..82068e55a7 100644
--- a/.github/workflows/integration-tests.yml
+++ b/.github/workflows/integration-tests.yml
@@ -34,7 +34,7 @@ env:
jobs:
test:
-
+ name: Integration Tests
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/macos-build.yml b/.github/workflows/macos-build.yml
index 8145460560..25f64861ea 100644
--- a/.github/workflows/macos-build.yml
+++ b/.github/workflows/macos-build.yml
@@ -30,6 +30,7 @@ on:
jobs:
test:
+ name: Build with macos on JDK 11
runs-on: macos-latest
timeout-minutes: 30
steps:
diff --git a/.github/workflows/owasp-dep-check.yml b/.github/workflows/owasp-dep-check.yml
index 62c1550ada..3f169af95b 100644
--- a/.github/workflows/owasp-dep-check.yml
+++ b/.github/workflows/owasp-dep-check.yml
@@ -34,7 +34,7 @@ env:
jobs:
check:
-
+ name: OWASP Dependency Check
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/pr-validation.yml b/.github/workflows/pr-validation.yml
index 3ab7eaa729..87c983e457 100644
--- a/.github/workflows/pr-validation.yml
+++ b/.github/workflows/pr-validation.yml
@@ -34,7 +34,7 @@ env:
jobs:
check:
-
+ name: PR Validation
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/remaining-tests.yml b/.github/workflows/remaining-tests.yml
index e8f303924e..2cebc57922 100644
--- a/.github/workflows/remaining-tests.yml
+++ b/.github/workflows/remaining-tests.yml
@@ -34,7 +34,7 @@ env:
jobs:
test:
-
+ name: Remaining Tests
runs-on: ubuntu-latest
timeout-minutes: 120
steps:
diff --git a/.github/workflows/replication-tests.yml b/.github/workflows/replication-tests.yml
index 19b3c324bc..388fe30016 100644
--- a/.github/workflows/replication-tests.yml
+++ b/.github/workflows/replication-tests.yml
@@ -34,7 +34,7 @@ env:
jobs:
test:
-
+ name: Replication Tests
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/stream-tests.yml b/.github/workflows/stream-tests.yml
index 6aa2492fb2..36c55cac0d 100644
--- a/.github/workflows/stream-tests.yml
+++ b/.github/workflows/stream-tests.yml
@@ -33,7 +33,7 @@ env:
jobs:
test:
-
+ name: StreamStorage Tests
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/tls-tests.yml b/.github/workflows/tls-tests.yml
index e6fdcd1275..4107d4401a 100644
--- a/.github/workflows/tls-tests.yml
+++ b/.github/workflows/tls-tests.yml
@@ -34,7 +34,7 @@ env:
jobs:
test:
-
+ name: TLS Tests
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml
index 8618d25e6c..fe3f06df5b 100644
--- a/.github/workflows/windows-build.yml
+++ b/.github/workflows/windows-build.yml
@@ -30,6 +30,7 @@ on:
jobs:
test:
+ name: Build with windows on JDK 11
runs-on: windows-latest
timeout-minutes: 30
steps: