You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Noa Resare <no...@resare.com> on 2013/03/02 14:55:58 UTC
Review Request: 4.1 deb packaging tomcat fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9714/
-----------------------------------------------------------
Review request for cloudstack and Wido den Hollander.
Description
-------
Changes isolated to the deb package build files, to fix
failure to start management server from deb built packages
* Adds the tomcat6 bootstrap jar to outer classpath
* Removes install of cloud-server-4.1.0-SNAPSHOT.jar
in /usr/share/cloudstack-management/lib. This causes
/usr/share/cloudstack-management structure to be in the
way tomcat expects it to
* Update paths to logfiles, which restores log4j functionality
CLOUDSTACK-1490: 4.1 deb management fails to start
This addresses bug CLOUDSTACK-1490.
Diffs
-----
debian/rules d537d86
packaging/debian/replace.properties d891e79
Diff: https://reviews.apache.org/r/9714/diff/
Testing
-------
Thanks,
Noa Resare
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Animesh Chaturvedi <An...@citrix.com>.
> On March 31, 2013, 3:03 p.m., Wido den Hollander wrote:
> > Ship It!
Wido is this in master now?
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9714/#review18567
-----------------------------------------------------------
On March 2, 2013, 11:34 p.m., Noa Resare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9714/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 11:34 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Description
> -------
>
> Changes isolated to the deb package build files, to fix
> failure to start management server from deb built packages
>
> * Adds the tomcat6 bootstrap jar to outer classpath
> * Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> in /usr/share/cloudstack-management/lib. This causes
> /usr/share/cloudstack-management structure to be in the
> way tomcat expects it to
> * Update paths to logfiles, which restores log4j functionality
>
> CLOUDSTACK-1490: 4.1 deb management fails to start
>
>
> This addresses bug CLOUDSTACK-1490.
>
>
> Diffs
> -----
>
> debian/rules ba9056e
> packaging/debian/replace.properties fee1def
>
> Diff: https://reviews.apache.org/r/9714/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Noa Resare
>
>
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Wido den Hollander <wi...@widodh.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9714/#review18567
-----------------------------------------------------------
Ship it!
Ship It!
- Wido den Hollander
On March 2, 2013, 11:34 p.m., Noa Resare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9714/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 11:34 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Description
> -------
>
> Changes isolated to the deb package build files, to fix
> failure to start management server from deb built packages
>
> * Adds the tomcat6 bootstrap jar to outer classpath
> * Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> in /usr/share/cloudstack-management/lib. This causes
> /usr/share/cloudstack-management structure to be in the
> way tomcat expects it to
> * Update paths to logfiles, which restores log4j functionality
>
> CLOUDSTACK-1490: 4.1 deb management fails to start
>
>
> This addresses bug CLOUDSTACK-1490.
>
>
> Diffs
> -----
>
> debian/rules ba9056e
> packaging/debian/replace.properties fee1def
>
> Diff: https://reviews.apache.org/r/9714/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Noa Resare
>
>
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Chip Childers <ch...@sungard.com>.
Let me know when you guys are ready to move it to 4.1. Thanks!
On Mar 2, 2013, at 6:34 PM, Noa Resare <no...@resare.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9714/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 11:34 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Description
> -------
>
> Changes isolated to the deb package build files, to fix
> failure to start management server from deb built packages
>
> * Adds the tomcat6 bootstrap jar to outer classpath
> * Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> in /usr/share/cloudstack-management/lib. This causes
> /usr/share/cloudstack-management structure to be in the
> way tomcat expects it to
> * Update paths to logfiles, which restores log4j functionality
>
> CLOUDSTACK-1490: 4.1 deb management fails to start
>
>
> This addresses bug CLOUDSTACK-1490.
>
>
> Diffs
> -----
>
> debian/rules ba9056e
> packaging/debian/replace.properties fee1def
>
> Diff: https://reviews.apache.org/r/9714/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Noa Resare
>
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Chip Childers <ch...@sungard.com>.
On Thu, Mar 14, 2013 at 12:04:27PM -0700, Animesh Chaturvedi wrote:
> Wido, Noa
>
> Any updates on this patch. We are closing on 4.1 so appreciate early response
>
> Animesh
Wido got this to me - I just pushed to 4.1.
>
> > -----Original Message-----
> > From: Chip Childers [mailto:chip.childers@sungard.com]
> > Sent: Wednesday, March 06, 2013 7:51 AM
> > To: Wido den Hollander
> > Cc: cloudstack-dev@incubator.apache.org; Noa Resare
> > Subject: Re: Review Request: 4.1 deb packaging tomcat fixes
> >
> > On Wed, Mar 06, 2013 at 04:48:55PM +0100, Wido den Hollander wrote:
> > >
> > > On 03/06/2013 04:46 PM, Chip Childers wrote:
> > > >Wido / Noa:
> > > >
> > > >Is this ready to pull into 4.1?
> > > >
> > >
> > > I've been debugging the agent and common package the last couple of
> > days.
> > >
> > > The packages themself seem to work, but it's all the small tweaks
> > > which take time.
> > >
> > > The agent package should be pretty stable now. It is spread out over
> > > multiple commits though, so they have to be cherry-picked.
> >
> > OK - so ideally it would be a clean patch. But if you get things to a point
> > where you want them moved to 4.1, and need it to be a set of cherry-picks,
> > please just provide the (ordered) list of commit-sh values.
> >
> > >
> > > Wido
> > >
> > > >
> > > >On Sat, Mar 02, 2013 at 11:34:14PM +0000, Noa Resare wrote:
> > > >>
> > > >>-----------------------------------------------------------
> > > >>This is an automatically generated e-mail. To reply, visit:
> > > >>https://reviews.apache.org/r/9714/
> > > >>-----------------------------------------------------------
> > > >>
> > > >>(Updated March 2, 2013, 11:34 p.m.)
> > > >>
> > > >>
> > > >>Review request for cloudstack and Wido den Hollander.
> > > >>
> > > >>
> > > >>Description
> > > >>-------
> > > >>
> > > >>Changes isolated to the deb package build files, to fix failure to
> > > >>start management server from deb built packages
> > > >>
> > > >>* Adds the tomcat6 bootstrap jar to outer classpath
> > > >>* Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> > > >> in /usr/share/cloudstack-management/lib. This causes
> > > >> /usr/share/cloudstack-management structure to be in the
> > > >> way tomcat expects it to
> > > >>* Update paths to logfiles, which restores log4j functionality
> > > >>
> > > >>CLOUDSTACK-1490: 4.1 deb management fails to start
> > > >>
> > > >>
> > > >>This addresses bug CLOUDSTACK-1490.
> > > >>
> > > >>
> > > >>Diffs
> > > >>-----
> > > >>
> > > >> debian/rules ba9056e
> > > >> packaging/debian/replace.properties fee1def
> > > >>
> > > >>Diff: https://reviews.apache.org/r/9714/diff/
> > > >>
> > > >>
> > > >>Testing
> > > >>-------
> > > >>
> > > >>
> > > >>Thanks,
> > > >>
> > > >>Noa Resare
> > > >>
> > >
> > >
>
RE: Review Request: 4.1 deb packaging tomcat fixes
Posted by Animesh Chaturvedi <an...@citrix.com>.
Wido, Noa
Any updates on this patch. We are closing on 4.1 so appreciate early response
Animesh
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Wednesday, March 06, 2013 7:51 AM
> To: Wido den Hollander
> Cc: cloudstack-dev@incubator.apache.org; Noa Resare
> Subject: Re: Review Request: 4.1 deb packaging tomcat fixes
>
> On Wed, Mar 06, 2013 at 04:48:55PM +0100, Wido den Hollander wrote:
> >
> > On 03/06/2013 04:46 PM, Chip Childers wrote:
> > >Wido / Noa:
> > >
> > >Is this ready to pull into 4.1?
> > >
> >
> > I've been debugging the agent and common package the last couple of
> days.
> >
> > The packages themself seem to work, but it's all the small tweaks
> > which take time.
> >
> > The agent package should be pretty stable now. It is spread out over
> > multiple commits though, so they have to be cherry-picked.
>
> OK - so ideally it would be a clean patch. But if you get things to a point
> where you want them moved to 4.1, and need it to be a set of cherry-picks,
> please just provide the (ordered) list of commit-sh values.
>
> >
> > Wido
> >
> > >
> > >On Sat, Mar 02, 2013 at 11:34:14PM +0000, Noa Resare wrote:
> > >>
> > >>-----------------------------------------------------------
> > >>This is an automatically generated e-mail. To reply, visit:
> > >>https://reviews.apache.org/r/9714/
> > >>-----------------------------------------------------------
> > >>
> > >>(Updated March 2, 2013, 11:34 p.m.)
> > >>
> > >>
> > >>Review request for cloudstack and Wido den Hollander.
> > >>
> > >>
> > >>Description
> > >>-------
> > >>
> > >>Changes isolated to the deb package build files, to fix failure to
> > >>start management server from deb built packages
> > >>
> > >>* Adds the tomcat6 bootstrap jar to outer classpath
> > >>* Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> > >> in /usr/share/cloudstack-management/lib. This causes
> > >> /usr/share/cloudstack-management structure to be in the
> > >> way tomcat expects it to
> > >>* Update paths to logfiles, which restores log4j functionality
> > >>
> > >>CLOUDSTACK-1490: 4.1 deb management fails to start
> > >>
> > >>
> > >>This addresses bug CLOUDSTACK-1490.
> > >>
> > >>
> > >>Diffs
> > >>-----
> > >>
> > >> debian/rules ba9056e
> > >> packaging/debian/replace.properties fee1def
> > >>
> > >>Diff: https://reviews.apache.org/r/9714/diff/
> > >>
> > >>
> > >>Testing
> > >>-------
> > >>
> > >>
> > >>Thanks,
> > >>
> > >>Noa Resare
> > >>
> >
> >
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Chip Childers <ch...@sungard.com>.
On Wed, Mar 06, 2013 at 04:48:55PM +0100, Wido den Hollander wrote:
>
> On 03/06/2013 04:46 PM, Chip Childers wrote:
> >Wido / Noa:
> >
> >Is this ready to pull into 4.1?
> >
>
> I've been debugging the agent and common package the last couple of days.
>
> The packages themself seem to work, but it's all the small tweaks
> which take time.
>
> The agent package should be pretty stable now. It is spread out over
> multiple commits though, so they have to be cherry-picked.
OK - so ideally it would be a clean patch. But if you get things to a
point where you want them moved to 4.1, and need it to be a set of
cherry-picks, please just provide the (ordered) list of commit-sh
values.
>
> Wido
>
> >
> >On Sat, Mar 02, 2013 at 11:34:14PM +0000, Noa Resare wrote:
> >>
> >>-----------------------------------------------------------
> >>This is an automatically generated e-mail. To reply, visit:
> >>https://reviews.apache.org/r/9714/
> >>-----------------------------------------------------------
> >>
> >>(Updated March 2, 2013, 11:34 p.m.)
> >>
> >>
> >>Review request for cloudstack and Wido den Hollander.
> >>
> >>
> >>Description
> >>-------
> >>
> >>Changes isolated to the deb package build files, to fix
> >>failure to start management server from deb built packages
> >>
> >>* Adds the tomcat6 bootstrap jar to outer classpath
> >>* Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> >> in /usr/share/cloudstack-management/lib. This causes
> >> /usr/share/cloudstack-management structure to be in the
> >> way tomcat expects it to
> >>* Update paths to logfiles, which restores log4j functionality
> >>
> >>CLOUDSTACK-1490: 4.1 deb management fails to start
> >>
> >>
> >>This addresses bug CLOUDSTACK-1490.
> >>
> >>
> >>Diffs
> >>-----
> >>
> >> debian/rules ba9056e
> >> packaging/debian/replace.properties fee1def
> >>
> >>Diff: https://reviews.apache.org/r/9714/diff/
> >>
> >>
> >>Testing
> >>-------
> >>
> >>
> >>Thanks,
> >>
> >>Noa Resare
> >>
>
>
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Wido den Hollander <wi...@widodh.nl>.
On 03/06/2013 04:46 PM, Chip Childers wrote:
> Wido / Noa:
>
> Is this ready to pull into 4.1?
>
I've been debugging the agent and common package the last couple of days.
The packages themself seem to work, but it's all the small tweaks which
take time.
The agent package should be pretty stable now. It is spread out over
multiple commits though, so they have to be cherry-picked.
Wido
>
> On Sat, Mar 02, 2013 at 11:34:14PM +0000, Noa Resare wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9714/
>> -----------------------------------------------------------
>>
>> (Updated March 2, 2013, 11:34 p.m.)
>>
>>
>> Review request for cloudstack and Wido den Hollander.
>>
>>
>> Description
>> -------
>>
>> Changes isolated to the deb package build files, to fix
>> failure to start management server from deb built packages
>>
>> * Adds the tomcat6 bootstrap jar to outer classpath
>> * Removes install of cloud-server-4.1.0-SNAPSHOT.jar
>> in /usr/share/cloudstack-management/lib. This causes
>> /usr/share/cloudstack-management structure to be in the
>> way tomcat expects it to
>> * Update paths to logfiles, which restores log4j functionality
>>
>> CLOUDSTACK-1490: 4.1 deb management fails to start
>>
>>
>> This addresses bug CLOUDSTACK-1490.
>>
>>
>> Diffs
>> -----
>>
>> debian/rules ba9056e
>> packaging/debian/replace.properties fee1def
>>
>> Diff: https://reviews.apache.org/r/9714/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Noa Resare
>>
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Chip Childers <ch...@sungard.com>.
Wido / Noa:
Is this ready to pull into 4.1?
On Sat, Mar 02, 2013 at 11:34:14PM +0000, Noa Resare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9714/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 11:34 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Description
> -------
>
> Changes isolated to the deb package build files, to fix
> failure to start management server from deb built packages
>
> * Adds the tomcat6 bootstrap jar to outer classpath
> * Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> in /usr/share/cloudstack-management/lib. This causes
> /usr/share/cloudstack-management structure to be in the
> way tomcat expects it to
> * Update paths to logfiles, which restores log4j functionality
>
> CLOUDSTACK-1490: 4.1 deb management fails to start
>
>
> This addresses bug CLOUDSTACK-1490.
>
>
> Diffs
> -----
>
> debian/rules ba9056e
> packaging/debian/replace.properties fee1def
>
> Diff: https://reviews.apache.org/r/9714/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Noa Resare
>
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Noa Resare <no...@resare.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9714/
-----------------------------------------------------------
(Updated March 2, 2013, 11:34 p.m.)
Review request for cloudstack and Wido den Hollander.
Description
-------
Changes isolated to the deb package build files, to fix
failure to start management server from deb built packages
* Adds the tomcat6 bootstrap jar to outer classpath
* Removes install of cloud-server-4.1.0-SNAPSHOT.jar
in /usr/share/cloudstack-management/lib. This causes
/usr/share/cloudstack-management structure to be in the
way tomcat expects it to
* Update paths to logfiles, which restores log4j functionality
CLOUDSTACK-1490: 4.1 deb management fails to start
This addresses bug CLOUDSTACK-1490.
Diffs
-----
debian/rules ba9056e
packaging/debian/replace.properties fee1def
Diff: https://reviews.apache.org/r/9714/diff/
Testing
-------
Thanks,
Noa Resare
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Noa Resare <no...@resare.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9714/
-----------------------------------------------------------
(Updated March 2, 2013, 11:34 p.m.)
Review request for cloudstack and Wido den Hollander.
Changes
-------
The updated diff is against master. Let's get it in there first, and cherry-pick onto 4.1 after careful consideration.
Description
-------
Changes isolated to the deb package build files, to fix
failure to start management server from deb built packages
* Adds the tomcat6 bootstrap jar to outer classpath
* Removes install of cloud-server-4.1.0-SNAPSHOT.jar
in /usr/share/cloudstack-management/lib. This causes
/usr/share/cloudstack-management structure to be in the
way tomcat expects it to
* Update paths to logfiles, which restores log4j functionality
CLOUDSTACK-1490: 4.1 deb management fails to start
This addresses bug CLOUDSTACK-1490.
Diffs (updated)
-----
debian/rules ba9056e
packaging/debian/replace.properties fee1def
Diff: https://reviews.apache.org/r/9714/diff/
Testing
-------
Thanks,
Noa Resare
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Noa Resare <no...@resare.com>.
> On March 2, 2013, 4:35 p.m., Wido den Hollander wrote:
> > Seems partially right. This is against the 4.1 branch, correct? Since the logfile fixes are already in master.
> >
> > Best practice is to check master first and cherry pick stuff to 4.1
Yes, this is against the 4.1 branch.
cherry-pick from master sounds like a better way to do it. I'll update the patch
- Noa
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9714/#review17302
-----------------------------------------------------------
On March 2, 2013, 1:55 p.m., Noa Resare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9714/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 1:55 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Description
> -------
>
> Changes isolated to the deb package build files, to fix
> failure to start management server from deb built packages
>
> * Adds the tomcat6 bootstrap jar to outer classpath
> * Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> in /usr/share/cloudstack-management/lib. This causes
> /usr/share/cloudstack-management structure to be in the
> way tomcat expects it to
> * Update paths to logfiles, which restores log4j functionality
>
> CLOUDSTACK-1490: 4.1 deb management fails to start
>
>
> This addresses bug CLOUDSTACK-1490.
>
>
> Diffs
> -----
>
> debian/rules d537d86
> packaging/debian/replace.properties d891e79
>
> Diff: https://reviews.apache.org/r/9714/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Noa Resare
>
>
Re: Review Request: 4.1 deb packaging tomcat fixes
Posted by Wido den Hollander <wi...@widodh.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9714/#review17302
-----------------------------------------------------------
Seems partially right. This is against the 4.1 branch, correct? Since the logfile fixes are already in master.
Best practice is to check master first and cherry pick stuff to 4.1
- Wido den Hollander
On March 2, 2013, 1:55 p.m., Noa Resare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9714/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 1:55 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Description
> -------
>
> Changes isolated to the deb package build files, to fix
> failure to start management server from deb built packages
>
> * Adds the tomcat6 bootstrap jar to outer classpath
> * Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> in /usr/share/cloudstack-management/lib. This causes
> /usr/share/cloudstack-management structure to be in the
> way tomcat expects it to
> * Update paths to logfiles, which restores log4j functionality
>
> CLOUDSTACK-1490: 4.1 deb management fails to start
>
>
> This addresses bug CLOUDSTACK-1490.
>
>
> Diffs
> -----
>
> debian/rules d537d86
> packaging/debian/replace.properties d891e79
>
> Diff: https://reviews.apache.org/r/9714/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Noa Resare
>
>