You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/28 11:24:27 UTC

[GitHub] [ozone] bshashikant opened a new pull request #1526: HDDS-4399. Safe mode rule for piplelines should only consider open pipelines.

bshashikant opened a new pull request #1526:
URL: https://github.com/apache/ozone/pull/1526


   
   
   ## What changes were proposed in this pull request?
   Currently, for safe mode we consider all pipelines existing in DB for safe mode exit criteria. It ma happen that, SCM has the pipelines craeted , but none of the participants datanodes ever created these datanodes. In such cases, SCM fails to come out of safemode as these pipelines are never reported back to SCM.
   
   The idea here is to consider pipelines which are marked open during SCM startup.
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-4399
   
   ## How was this patch tested?
   Added unit tests
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [ozone] bharatviswa504 commented on pull request #1526: HDDS-4399. Safe mode rule for piplelines should only consider open pipelines.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1526:
URL: https://github.com/apache/ozone/pull/1526#issuecomment-729084263


   Thank You @bshashikant for the contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1526: HDDS-4399. Safe mode rule for piplelines should only consider open pipelines.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #1526:
URL: https://github.com/apache/ozone/pull/1526#discussion_r516427783



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/HealthyPipelineSafeModeRule.java
##########
@@ -118,7 +118,7 @@ protected void process(Pipeline pipeline) {
     Preconditions.checkNotNull(pipeline);
     if (pipeline.getType() == HddsProtos.ReplicationType.RATIS &&
         pipeline.getFactor() == HddsProtos.ReplicationFactor.THREE &&
-        pipeline.isHealthy() &&
+      //  pipeline.isHealthy() &&

Review comment:
       I understand now why we can remove this, we trigger open Pipeline event when healthy only. Can we remove the code comment completely.

##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/HealthyPipelineSafeModeRule.java
##########
@@ -118,7 +118,7 @@ protected void process(Pipeline pipeline) {
     Preconditions.checkNotNull(pipeline);
     if (pipeline.getType() == HddsProtos.ReplicationType.RATIS &&
         pipeline.getFactor() == HddsProtos.ReplicationFactor.THREE &&
-        pipeline.isHealthy() &&
+      //  pipeline.isHealthy() &&

Review comment:
       do we want to remove this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 merged pull request #1526: HDDS-4399. Safe mode rule for piplelines should only consider open pipelines.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #1526:
URL: https://github.com/apache/ozone/pull/1526


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bshashikant commented on pull request #1526: HDDS-4399. Safe mode rule for piplelines should only consider open pipelines.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1526:
URL: https://github.com/apache/ozone/pull/1526#issuecomment-725217845


   @bharatviswa504 @nandakumar131 can you please review?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org