[GitHub] [cassandra] dcapwell commented on a diff in pull request #2537: CASSANDRA-18713 Fix / align ConfigCompatibilityTest

["dcapwell (via GitHub)" <gi...@apache.org>]

dcapwell commented on code in PR #2537:
URL: https://github.com/apache/cassandra/pull/2537#discussion_r1280966228


##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -881,7 +881,7 @@ public static void setClientMode(boolean clientMode)
     @Replaces(oldName = "compaction_large_partition_warning_threshold", converter = Converters.LONG_BYTES_DATASTORAGE_MEBIBYTES_DATASTORAGE, deprecated = true)
     public volatile DataStorageSpec.LongBytesBound partition_size_warn_threshold = null;
     public volatile DataStorageSpec.LongBytesBound partition_size_fail_threshold = null;
-    @Replaces(oldName = "compaction_tombstone_warning_threshold", converter = Converters.IDENTITY, deprecated = true)
+    @Replaces(oldName = "compaction_tombstone_warning_threshold", converter = Converters.INTEGER_PRIMITIVE_LONG, deprecated = true)

Review Comment:
   ```
   $ cd cassandra-4.1
   $ grep compaction_tombstone_warning_threshold ./src/java/org/apache/cassandra/config/Config.java
       public volatile Integer compaction_tombstone_warning_threshold = 100000;
   ```
   
   +1
   



##########
test/data/config/version=3.0.0-alpha1.yml:
##########
@@ -39,6 +39,7 @@ listen_address: "java.lang.String"
 native_transport_max_concurrent_connections_per_ip: "java.lang.Long"
 rpc_keepalive: "java.lang.Boolean"
 request_scheduler: "java.lang.String"
+allow_extra_insecure_udfs: "java.lang.Boolean"

Review Comment:
   I have no clue what this is, but I love that name... <3



##########
test/data/config/version=4.1-alpha1.yml:
##########
@@ -0,0 +1,424 @@
+---

Review Comment:
   thanks for adding this one!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org