[GitHub] [pulsar] nodece commented on a diff in pull request #19390: [fix][authentication] Store the original auth when using anonymous role

["nodece (via GitHub)" <gi...@apache.org>]

nodece commented on code in PR #19390:
URL: https://github.com/apache/pulsar/pull/19390#discussion_r1099616630


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -971,6 +973,7 @@ protected void handleConnect(CommandConnect connect) {
                 authRole = getBrokerService().getAuthenticationService().getAnonymousUserRole()

Review Comment:
   This means that the proxy cannot use the anonymous role to connect to the broker, I don't think this is correct.
   
   Usually, the proxy always enable the authentication feature, but we also should consider a case that the proxy doesn't enable the authentication feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org