[GitHub] marcoabreu commented on a change in pull request #14144: [WIP] Fixes installation nightly test

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #14144: [WIP] Fixes installation nightly test
URL: https://github.com/apache/incubator-mxnet/pull/14144#discussion_r256401221
 
 

 ##########
 File path: tests/jenkins/run_test_installation_docs.sh
 ##########
 @@ -302,7 +304,7 @@ ubuntu_python_cpu_source()
     set -e
     echo
     echo "### Testing Build From Source ###"
-    echo "${buildfromsource_commands}"
+    buildfromsource_commands=${buildfromsource_commands//cd incubator-mxnet;/cd incubator-mxnet; git checkout ${GIT_SHA}; git submodule update;}
 
 Review comment:
   Jenkins already makes sure you are in the correct git state and hash. Doing a manual change of the git state (e.g. by executing clone or checkout) can result in corruption of the state and thus lead to unexpected result. You can assume that Jenkins checked out the hash that it's supposed to validate. This approach allows us to stay independent of any external resources and fully operate on the git source that the job was requested to run on.
   
   If there's any other git stuff happening during this process (since it's intended for endusers), I'd recommend to filter them as part of this execution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services