[jira] [Commented] (LUCENE-7092) Point range factory methods for excluded bounds

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189074#comment-15189074 ] 

Robert Muir commented on LUCENE-7092:
-------------------------------------

The problem with this is that client code tends to look much better once you really remove the brain damage. Those nulls and booleans were really just that, brain damage from termrangequery. I agree if you "just" try to wedge in points, without doing proper cleanups, then its ugly.

You can see that in the commit of LUCENE-7061, it just removes a ton of code!

In other words: remove things like nulls and include/exclude options to the user at all and give them a similar api. Why does a user need exclusive range on an ip address? They don't, users care about networks. It makes absolutely no sense!


> Point range factory methods for excluded bounds
> -----------------------------------------------
>
>                 Key: LUCENE-7092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7092
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>
> I am playing with using the new points API with elasticsearch and one challenge is to generate range queries whose bounds are excluded, which is something that was very easy with the previous numerics implementation. It is easy to do externally with ints, but becomes tricky with floats or ip addresses. Maybe we should have factory methods that take 2 additional booleans to allow the bounds to be excluded?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org