You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by su...@apache.org on 2019/03/15 18:50:22 UTC
[incubator-pinot] branch master updated: Make RetentionManager and
OfflineSegmentIntervalChecker initial delays configurable (#3946)
This is an automated email from the ASF dual-hosted git repository.
sunithabeeram pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b2c5a88 Make RetentionManager and OfflineSegmentIntervalChecker initial delays configurable (#3946)
b2c5a88 is described below
commit b2c5a882fb35f1be7bcaeb0f6c65c28a8f1d7ff9
Author: Sunitha Beeram <sb...@linkedin.com>
AuthorDate: Fri Mar 15 11:50:17 2019 -0700
Make RetentionManager and OfflineSegmentIntervalChecker initial delays configurable (#3946)
---
.../java/org/apache/pinot/controller/ControllerConf.java | 14 ++++++++++++++
.../controller/helix/core/retention/RetentionManager.java | 2 +-
.../validation/OfflineSegmentIntervalChecker.java | 2 +-
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java b/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
index 05203ae..1179996 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
@@ -84,6 +84,10 @@ public class ControllerConf extends PropertiesConfiguration {
// Initial delays
private static final String STATUS_CHECKER_INITIAL_DELAY_IN_SECONDS =
"controller.statusChecker.initialDelayInSeconds";
+ private static final String RETENTION_MANAGER_INITIAL_DELAY_IN_SECONDS =
+ "controller.retentionManager.initialDelayInSeconds";
+ private static final String OFFLINE_SEGMENT_INTERVAL_CHECKER_INITIAL_DELAY_IN_SECONDS =
+ "controller.offlineSegmentIntervalChecker.initialDelayInSeconds";
public static final int MIN_INITIAL_DELAY_IN_SECONDS = 120;
public static final int MAX_INITIAL_DELAY_IN_SECONDS = 300;
@@ -575,6 +579,16 @@ public class ControllerConf extends PropertiesConfiguration {
ControllerPeriodicTasksConf.getRandomInitialDelayInSeconds());
}
+ public long getRetentionManagerInitialDelayInSeconds() {
+ return getLong(ControllerPeriodicTasksConf.RETENTION_MANAGER_INITIAL_DELAY_IN_SECONDS,
+ ControllerPeriodicTasksConf.getRandomInitialDelayInSeconds());
+ }
+
+ public long getOfflineSegmentIntervalCheckerInitialDelayInSeconds() {
+ return getLong(ControllerPeriodicTasksConf.OFFLINE_SEGMENT_INTERVAL_CHECKER_INITIAL_DELAY_IN_SECONDS,
+ ControllerPeriodicTasksConf.getRandomInitialDelayInSeconds());
+ }
+
public void setStatusCheckerInitialDelayInSeconds(long initialDelayInSeconds) {
setProperty(ControllerPeriodicTasksConf.STATUS_CHECKER_INITIAL_DELAY_IN_SECONDS, initialDelayInSeconds);
}
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
index b3abf07..b9f2bd5e 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
@@ -57,7 +57,7 @@ public class RetentionManager extends ControllerPeriodicTask<Void> {
public RetentionManager(PinotHelixResourceManager pinotHelixResourceManager, ControllerConf config,
ControllerMetrics controllerMetrics) {
super("RetentionManager", config.getRetentionControllerFrequencyInSeconds(),
- config.getPeriodicTaskInitialDelayInSeconds(), pinotHelixResourceManager, controllerMetrics);
+ config.getRetentionManagerInitialDelayInSeconds(), pinotHelixResourceManager, controllerMetrics);
_deletedSegmentsRetentionInDays = config.getDeletedSegmentsRetentionInDays();
LOGGER.info("Starting RetentionManager with runFrequencyInSeconds: {}, deletedSegmentsRetentionInDays: {}",
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentIntervalChecker.java b/pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentIntervalChecker.java
index 2646ddd..b01aa27 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentIntervalChecker.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentIntervalChecker.java
@@ -51,7 +51,7 @@ public class OfflineSegmentIntervalChecker extends ControllerPeriodicTask<Void>
public OfflineSegmentIntervalChecker(ControllerConf config, PinotHelixResourceManager pinotHelixResourceManager,
ValidationMetrics validationMetrics, ControllerMetrics controllerMetrics) {
super("OfflineSegmentIntervalChecker", config.getOfflineSegmentIntervalCheckerFrequencyInSeconds(),
- config.getPeriodicTaskInitialDelayInSeconds(), pinotHelixResourceManager, controllerMetrics);
+ config.getOfflineSegmentIntervalCheckerInitialDelayInSeconds(), pinotHelixResourceManager, controllerMetrics);
_validationMetrics = validationMetrics;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org