[jira] [Commented] (CLOUDSTACK-9473) Storage pool checker is ignored on resize and migrate volume.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599632#comment-16599632 ] 

ASF GitHub Bot commented on CLOUDSTACK-9473:
--------------------------------------------

rafaelweingartner commented on a change in pull request #2829: CLOUDSTACK-9473: storage pool capacity check when volume is resized or migrated
URL: https://github.com/apache/cloudstack/pull/2829#discussion_r214514105
 
 

 ##########
 File path: server/src/com/cloud/storage/StorageManagerImpl.java
 ##########
 @@ -1847,21 +1872,26 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool,
         s_logger.debug("Total capacity of the pool " + poolVO.getName() + " with ID " + pool.getId() + " is " + totalOverProvCapacity);
 
         double storageAllocatedThreshold = CapacityManager.StorageAllocatedCapacityDisableThreshold.valueIn(pool.getDataCenterId());
-
-        s_logger.debug("Checking pool: " + pool.getId() + " for volume allocation " + volumes.toString() + ", maxSize : " + totalOverProvCapacity + ", totalAllocatedSize : "
-                + allocatedSizeWithTemplate + ", askingSize : " + totalAskingSize + ", allocated disable threshold: " + storageAllocatedThreshold);
+        if (s_logger.isDebugEnabled()) {
 
 Review comment:
   I still see no real benefits of adding this log level checks in our context. On the other hand, I do see problems with readability of the code. 
   
   I cannot object though, if you want to proceed with this ;) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Storage pool checker is ignored on resize and migrate volume.
> -------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9473
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9473
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Storage Controller
>    Affects Versions: 4.9.0
>         Environment: * VMware vCenter 5.5U3/ESXi 5.0 U1 
> * ACS 4.9 running on CentOS6.4
>            Reporter: Boris Stoyanov
>            Priority: Major
>
> *Description:*
> Storage pool checker is not being called on resize and migrate volume. This may lead to allocated percentage of storage above 100%. 
> *Setup:*
> 1 VMware cluster with 2 Hosts.
> *Executed Steps:*
> # Applied the following global settings: 
> #* storage.overprovisioning.factor = 1 
> #* pool.storage.allocated.capacity.disablethreshold = 1
> #* pool.storage.capacity.disablethreshold = 1
> # Restarted management server
> # Executed Resize and migrate pool and Observed that Storage pool checker is not performed on resizeVolume and migrateVolume.
> *Result:*
> Root cause analysis shows storage pool checker is not called when doing migration and resizing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)