[GitHub] [arrow-datafusion] alamb edited a comment on issue #1549: Proposal: Remove `Accumulator::update` and `Accumulator::merge`

[GitBox <gi...@apache.org>]

alamb edited a comment on issue #1549:
URL: https://github.com/apache/arrow-datafusion/issues/1549#issuecomment-1012197926


   @liukun4515 
   
   > Can we change the default implementation of the accumulator trait to this?
   
   We could change the default implementation, however, I am not sure what purpose that would serve -- the code in datafusion that calls `Accumulator` only (should) use `Accumulator::update_batch` 
   
   I was thinking of moving the current default implementation of `Accumulator::update_batch` which calls `update()` with `ScalarValues` to some sort of public  example or adapter function, so anyone who had existing Accumulator implementations can continue to use them until they move over to `update_batch` and `merge_batch`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org