You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2023/07/12 00:01:08 UTC
[superset] branch 2.1 updated (f6b5d4e84d -> 8bc8d33a50)
This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a change to branch 2.1
in repository https://gitbox.apache.org/repos/asf/superset.git
omit f6b5d4e84d fix: dashboard ownership check (#24249)
omit 0426367437 fix(permalink): migrate to marshmallow codec (#24166)
new 8bc8d33a50 fix: dashboard ownership check (#24249)
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (f6b5d4e84d)
\
N -- N -- N refs/heads/2.1 (8bc8d33a50)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
superset/dashboards/permalink/api.py | 6 +-
superset/dashboards/permalink/commands/base.py | 9 +-
superset/dashboards/permalink/commands/create.py | 3 -
superset/dashboards/permalink/commands/get.py | 7 +-
superset/dashboards/permalink/schemas.py | 11 +-
superset/explore/permalink/api.py | 6 +-
superset/explore/permalink/commands/base.py | 9 +-
superset/explore/permalink/commands/create.py | 3 -
superset/explore/permalink/commands/get.py | 7 +-
superset/explore/permalink/schemas.py | 26 +----
superset/key_value/types.py | 36 +-----
.../explore/permalink/api_tests.py | 16 +--
tests/unit_tests/key_value/codec_test.py | 122 ---------------------
13 files changed, 22 insertions(+), 239 deletions(-)
delete mode 100644 tests/unit_tests/key_value/codec_test.py
[superset] 01/01: fix: dashboard ownership check (#24249)
Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 8bc8d33a5037e0a9028954370042d80a4880085b
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Tue May 30 12:18:20 2023 -0700
fix: dashboard ownership check (#24249)
(cherry picked from commit 7e70f19b6829eb7226cb53da9eeb1aff83b18dbe)
---
superset-frontend/src/dashboard/util/permissionUtils.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset-frontend/src/dashboard/util/permissionUtils.ts b/superset-frontend/src/dashboard/util/permissionUtils.ts
index 3ea63976bf..6a218349b2 100644
--- a/superset-frontend/src/dashboard/util/permissionUtils.ts
+++ b/superset-frontend/src/dashboard/util/permissionUtils.ts
@@ -42,7 +42,7 @@ const isUserDashboardOwner = (
user: UserWithPermissionsAndRoles | UndefinedUser,
) =>
isUserWithPermissionsAndRoles(user) &&
- dashboard.owners.some(owner => owner.username === user.username);
+ dashboard.owners.some(owner => owner.id === user.userId);
export const canUserEditDashboard = (
dashboard: Dashboard,