You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2005/01/28 18:54:28 UTC
[PATCH]: Fix some pool usage (non-use of sub-pools)
I came across these while going through Michael Price's patch for issue #1310.
Log message:
[[[
Fix some pool usage.
* subversion/libsvn_client/add.c
(svn_client_mkdir): Actually use the sub-pool that we created. Clear it at
at the beginning rather than the end of the loop, as per our policy.
* subversion/mod_dav_svn/repos.c
(dav_svn_do_walk): Remove the unused sub-pool, as no pool is needed.
]]]
- Julian
Re: [PATCH]: Fix some pool usage (non-use of sub-pools)
Posted by Julian Foad <ju...@btopenworld.com>.
kfogel@collab.net wrote:
> +1 on both, nice catches!
Committed in r12954.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH]: Fix some pool usage (non-use of sub-pools)
Posted by kf...@collab.net.
Julian Foad <ju...@btopenworld.com> writes:
> Log message:
> [[[
> Fix some pool usage.
>
> * subversion/libsvn_client/add.c
> (svn_client_mkdir): Actually use the sub-pool that we created. Clear it at
> at the beginning rather than the end of the loop, as per our policy.
>
> * subversion/mod_dav_svn/repos.c
> (dav_svn_do_walk): Remove the unused sub-pool, as no pool is needed.
> ]]]
+1 on both, nice catches!
These cleanups are great. You're becoming, like, the drill sergeant
of the svn code. "If a quarter doesn't bounce off this subroutine,
it's not tight enough!" :-)
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org