You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/06/22 19:24:01 UTC
[GitHub] [helix] kaisun2000 opened a new pull request #1112: Merge watcher branch to master
kaisun2000 opened a new pull request #1112:
URL: https://github.com/apache/helix/pull/1112
This is to fix #1034
Current watcher short term fix is completed. Please merge it to apache/master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1112: Merge watcher branch to master
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1112:
URL: https://github.com/apache/helix/pull/1112#issuecomment-647817336
This does not look right. Have you rebased to the master in your branch before creating this PR? Hint, you might need to resolve some conflict and clean up the branch so it is a clean merge PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on pull request #1112: Merge watcher branch to master
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1112:
URL: https://github.com/apache/helix/pull/1112#issuecomment-647922587
I thought you would do the merge to master from apache/watcher branch. If I rebase apache/watcher to apache/master, we need to review it quickly or master may move again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 closed pull request #1112: Merge watcher branch to master
Posted by GitBox <gi...@apache.org>.
kaisun2000 closed pull request #1112:
URL: https://github.com/apache/helix/pull/1112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on pull request #1112: Merge watcher branch to master
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1112:
URL: https://github.com/apache/helix/pull/1112#issuecomment-647932529
Created pull request https://github.com/apache/helix/pull/1115 as I can't change the comparison branches here. Closing this one. Can you have a look at 1115?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org