[GitHub] [ozone] neils-dev commented on a diff in pull request #4140: HDDS-7721. Make OM Ratis roles available in /prom endpoint

[GitBox <gi...@apache.org>]

neils-dev commented on code in PR #4140:
URL: https://github.com/apache/ozone/pull/4140#discussion_r1081818641


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithData.java:
##########
@@ -104,6 +105,30 @@ public void testMultipartUpload() throws Exception {
     testMultipartUploadWithOneOmNodeDown();
   }
 
+  @Test
+  public void testOMHAMetrics() throws InterruptedException {
+    Thread.sleep(2000);

Review Comment:
   Having a sleep in a test can be a cause of 'flaky' tests depending on the load of system at time of test.  Can we change this to be a sleep conditional and use a `genericTestUtils.waitFor(() -> {...}, checkEveryMillis, waitForMillis)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org