You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/22 21:36:42 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #8995:
[druid] Making scaning/refreshing Druid datasource view items optional
john-bodley opened a new pull request #8995: [druid] Making scaning/refreshing Druid datasource view items optional
URL: https://github.com/apache/incubator-superset/pull/8995
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Some deployments with charts backed by the legacy Druid NoSQL connector can't simply go cold turkey on fully disabling Druid however we would like to wean ourselves off starting by removing the option to scan for new or refresh the metadata of the Druid datasources. Note the later menu item is somewhat of a misnomer as it refreshes all Druid datasource from the source and not just those currently registered in Superset.
This PR adds a config option to simply remove the view items for scanning/refreshing Druid datasources.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### BEFORE
When `DRUID_IS_ACTIVE = True` (non-default) and `DRUID_METADATA_VIEW_LINKS = True` (default)
#### AFTER
When `DRUID_IS_ACTIVE = True` (non-default) and `DRUID_METADATA_VIEW_LINKS = False` (non-default)
### TEST PLAN
CI and tested locally.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @michellethomas @mistercrunch @willbarrett
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#8995: [druid] Making scaning/refreshing Druid datasource view items optional
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #8995: [druid] Making scaning/refreshing Druid datasource view items optional
URL: https://github.com/apache/incubator-superset/pull/8995#discussion_r369853458
##########
File path: superset/config.py
##########
@@ -191,11 +191,16 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument
DRUID_TZ = tz.tzutc()
DRUID_ANALYSIS_TYPES = ["cardinality"]
-# Legacy Druid connector
+# Legacy Druid NoSQL (native) connector
# Druid supports a SQL interface in its newer versions.
# Setting this flag to True enables the deprecated, API-based Druid
# connector. This feature may be removed at a future date.
-DRUID_IS_ACTIVE = False
+DRUID_IS_ACTIVE = True
+
+# If Druid is active whether to include the links to scan/refresh Druid datasources.
+# This should be disable if you are trying to wean yourself off of the Druid NoSQL
+# connector.
+DRUID_METADATA_VIEW_LINKS = True
Review comment:
maybe `DRUID_METADATA_LINKS_ENABLED`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#8995: [druid] Making scaning/refreshing Druid datasource view items optional
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #8995: [druid] Making scaning/refreshing Druid datasource view items optional
URL: https://github.com/apache/incubator-superset/pull/8995#discussion_r369853186
##########
File path: superset/config.py
##########
@@ -191,11 +191,16 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument
DRUID_TZ = tz.tzutc()
DRUID_ANALYSIS_TYPES = ["cardinality"]
-# Legacy Druid connector
+# Legacy Druid NoSQL (native) connector
# Druid supports a SQL interface in its newer versions.
# Setting this flag to True enables the deprecated, API-based Druid
# connector. This feature may be removed at a future date.
-DRUID_IS_ACTIVE = False
+DRUID_IS_ACTIVE = True
+
+# If Druid is active whether to include the links to scan/refresh Druid datasources.
+# This should be disable if you are trying to wean yourself off of the Druid NoSQL
Review comment:
sp nit: `This should be disabled`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #8995: [druid]
Making scaning/refreshing Druid datasource view items optional
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #8995: [druid] Making scaning/refreshing Druid datasource view items optional
URL: https://github.com/apache/incubator-superset/pull/8995#issuecomment-577412409
YASSSS...LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull
request #8995: [druid] Making scaning/refreshing Druid datasource view
items optional
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #8995: [druid] Making scaning/refreshing Druid datasource view items optional
URL: https://github.com/apache/incubator-superset/pull/8995#discussion_r369857663
##########
File path: superset/config.py
##########
@@ -191,11 +191,16 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument
DRUID_TZ = tz.tzutc()
DRUID_ANALYSIS_TYPES = ["cardinality"]
-# Legacy Druid connector
+# Legacy Druid NoSQL (native) connector
# Druid supports a SQL interface in its newer versions.
# Setting this flag to True enables the deprecated, API-based Druid
# connector. This feature may be removed at a future date.
-DRUID_IS_ACTIVE = False
+DRUID_IS_ACTIVE = True
+
+# If Druid is active whether to include the links to scan/refresh Druid datasources.
+# This should be disable if you are trying to wean yourself off of the Druid NoSQL
+# connector.
+DRUID_METADATA_VIEW_LINKS = True
Review comment:
Agreed. The `VIEW` term related to FAB views but the way it reads it's misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8995: [druid]
Making scaning/refreshing Druid datasource view items optional
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8995: [druid] Making scaning/refreshing Druid datasource view items optional
URL: https://github.com/apache/incubator-superset/pull/8995#issuecomment-577439488
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8995?src=pr&el=h1) Report
> Merging [#8995](https://codecov.io/gh/apache/incubator-superset/pull/8995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e46ff239afc79af5753cfe82779fa87796f46a27?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8995 +/- ##
==========================================
- Coverage 59.16% 59.16% -0.01%
==========================================
Files 367 367
Lines 11679 11680 +1
Branches 2862 2863 +1
==========================================
Hits 6910 6910
- Misses 4590 4591 +1
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8995/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `77.55% <0%> (-0.8%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8995?src=pr&el=footer). Last update [e46ff23...f6366bb](https://codecov.io/gh/apache/incubator-superset/pull/8995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #8995: [druid]
Making scaning/refreshing Druid datasource view items optional
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #8995: [druid] Making scaning/refreshing Druid datasource view items optional
URL: https://github.com/apache/incubator-superset/pull/8995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org