You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/10/20 09:50:31 UTC
[GitHub] tajo pull request: TAJO-1941: PermGen elimination in JDK 8
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/833
TAJO-1941: PermGen elimination in JDK 8
The Permanent Generation (PermGen) space has completely been removed and is kind of replaced by a new space called Metaspace in JDK 8. So, I replace it to avoid WARN message and get performence improvement.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo TAJO-1941
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/833.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #833
----
commit 0ea77d436663732e9691272c8ef494c5a85b553b
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date: 2015-10-20T07:48:17Z
initial commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1941: PermGen elimination in JDK 8
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/833#issuecomment-153207532
With this option, Infinite GC POOL is occured during parallel test and cannot run next test. To avoid this phenomenon, I enter the parallel test without XX:MaxMetaspaceSize.
Currently, Whole test of TAJO is running without this option after version up of JAVA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1941: PermGen elimination in JDK 8
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/833#issuecomment-153429148
That may be size matter because JVM basically uses a default value for XX:MaxMetaspaceSize.
Even though it may need more investigation for finding actual reason, It would be good to go ahead.
Here is my +1. Thank you for your work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1941: PermGen elimination in JDK 8
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/833#issuecomment-153408862
@hyunsik in parallel test, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1941: PermGen elimination in JDK 8
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/833#issuecomment-153402764
@dkhwangbo Do you mean that ``XX:MaxMetaspaceSize`` causes hanging unit tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1941: PermGen elimination in JDK 8
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/833
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1941: PermGen elimination in JDK 8
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/833#discussion_r43654839
--- Diff: tajo-core-tests/pom.xml ---
@@ -375,7 +375,7 @@
<forkCount>${maven.fork.count}</forkCount>
<reuseForks>true</reuseForks>
<trimStackTrace>false</trimStackTrace>
- <argLine>-Xms512m -Xmx1024m -XX:MaxPermSize=152m -Dfile.encoding=UTF-8 -Dderby.storage.pageSize=1024 -Dderby.stream.error.file=/dev/null</argLine>
+ <argLine>-Xms512m -Xmx1024m -Dfile.encoding=UTF-8 -Dderby.storage.pageSize=1024 -Dderby.stream.error.file=/dev/null</argLine>
--- End diff --
Any reason to omit ``XX:MaxMetaspaceSize`` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1941: PermGen elimination in JDK 8
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on a diff in the pull request:
https://github.com/apache/tajo/pull/833#discussion_r43705523
--- Diff: tajo-core-tests/pom.xml ---
@@ -375,7 +375,7 @@
<forkCount>${maven.fork.count}</forkCount>
<reuseForks>true</reuseForks>
<trimStackTrace>false</trimStackTrace>
- <argLine>-Xms512m -Xmx1024m -XX:MaxPermSize=152m -Dfile.encoding=UTF-8 -Dderby.storage.pageSize=1024 -Dderby.stream.error.file=/dev/null</argLine>
+ <argLine>-Xms512m -Xmx1024m -Dfile.encoding=UTF-8 -Dderby.storage.pageSize=1024 -Dderby.stream.error.file=/dev/null</argLine>
--- End diff --
With this option, Infinite GC POOL is occured during parallel test and cannot run next test. To avoid this phenomenon, I enter the parallel test without XX:MaxMetaspaceSize.
Currently, Whole test of TAJO is running without this option after version up of JAVA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---