You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/24 07:21:30 UTC
[GitHub] [druid] zachjsh opened a new pull request #9394: Move Azure
extension into Core
zachjsh opened a new pull request #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394
Moving the azure extension into Core.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9394:
Move Azure extension into Core
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394#discussion_r383785434
##########
File path: docs/development/extensions.md
##########
@@ -72,7 +72,7 @@ All of these community extensions can be downloaded using [pull-deps](../operati
|Name|Description|Docs|
|----|-----------|----|
|ambari-metrics-emitter|Ambari Metrics Emitter |[link](../development/extensions-contrib/ambari-metrics-emitter.md)|
-|druid-azure-extensions|Microsoft Azure deep storage.|[link](../development/extensions-contrib/azure.md)|
+|druid-azure-extensions|Microsoft Azure deep storage.|[link](extensions-core/azure.md)|
Review comment:
This should be moved up into the core extensions section instead of the contrib section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on issue #9394: Move Azure extension
into Core
Posted by GitBox <gi...@apache.org>.
ccaominh commented on issue #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394#issuecomment-590464382
"docs" job is failing due to broken link: https://travis-ci.org/apache/druid/jobs/654285936#L296
"license check" job is failing due to unknown license: https://travis-ci.org/apache/druid/jobs/654285913#L2991
You'll need to add an entry here for "The MIT License (MIT)": https://github.com/apache/druid/blob/master/distribution/bin/check-licenses.py#L270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zachjsh commented on a change in pull request #9394: Move
Azure extension into Core
Posted by GitBox <gi...@apache.org>.
zachjsh commented on a change in pull request #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394#discussion_r384160425
##########
File path: distribution/pom.xml
##########
@@ -197,6 +197,8 @@
<argument>-c</argument>
<argument>org.apache.druid.extensions:druid-avro-extensions</argument>
<argument>-c</argument>
+ <argument>org.apache.druid.extensions:druid-azure-extensions</argument>
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9394:
Move Azure extension into Core
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394#discussion_r383785191
##########
File path: distribution/pom.xml
##########
@@ -197,6 +197,8 @@
<argument>-c</argument>
<argument>org.apache.druid.extensions:druid-avro-extensions</argument>
<argument>-c</argument>
+ <argument>org.apache.druid.extensions:druid-azure-extensions</argument>
Review comment:
You should also remove this from the [`bundle-contrib-exts` profile](https://github.com/apache/druid/blob/master/distribution/pom.xml#L385)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9394:
Move Azure extension into Core
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394#discussion_r383787536
##########
File path: website/sidebars.json
##########
@@ -169,8 +169,8 @@
"development/extensions-core/simple-client-sslcontext",
"development/extensions-core/stats",
"development/extensions-core/test-stats",
+ "development/extensions-core/azure",
Review comment:
super nit that doesn't matter at all: maybe put up by avro so its in alphabetical order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #9394: Move Azure
extension into Core
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zachjsh commented on a change in pull request #9394: Move
Azure extension into Core
Posted by GitBox <gi...@apache.org>.
zachjsh commented on a change in pull request #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394#discussion_r384160336
##########
File path: docs/development/extensions.md
##########
@@ -72,7 +72,7 @@ All of these community extensions can be downloaded using [pull-deps](../operati
|Name|Description|Docs|
|----|-----------|----|
|ambari-metrics-emitter|Ambari Metrics Emitter |[link](../development/extensions-contrib/ambari-metrics-emitter.md)|
-|druid-azure-extensions|Microsoft Azure deep storage.|[link](../development/extensions-contrib/azure.md)|
+|druid-azure-extensions|Microsoft Azure deep storage.|[link](extensions-core/azure.md)|
Review comment:
fixes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zachjsh commented on a change in pull request #9394: Move
Azure extension into Core
Posted by GitBox <gi...@apache.org>.
zachjsh commented on a change in pull request #9394: Move Azure extension into Core
URL: https://github.com/apache/druid/pull/9394#discussion_r384160385
##########
File path: website/sidebars.json
##########
@@ -169,8 +169,8 @@
"development/extensions-core/simple-client-sslcontext",
"development/extensions-core/stats",
"development/extensions-core/test-stats",
+ "development/extensions-core/azure",
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org