[GitHub] [spark] zhengruifeng commented on a diff in pull request #41435: [SPARK-43943][SQL][PYTHON][CONNECT] Add SQL math functions to Scala and Python

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #41435:
URL: https://github.com/apache/spark/pull/41435#discussion_r1220725034


##########
python/docs/source/reference/pyspark.sql/functions.rst:
##########
@@ -64,31 +64,39 @@ Math Functions
     bin
     cbrt
     ceil
+    ceiling
     conv
     cos
     cosh
     cot
     csc
+    e
     exp
     expm1
     factorial
     floor
     hex
     unhex
     hypot
+    ln
     log
     log10
     log1p
     log2
+    negative

Review Comment:
   @HyukjinKwon they were added here. except the `negate`, I will add it.
   
   BTW, in the last commit I add `negate` (which only existed in scala) to the python side for the parity between py and scala



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org