[GitHub] [airflow] mik-laj commented on a change in pull request #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once
URL: https://github.com/apache/airflow/pull/5685#discussion_r312918194
 
 

 ##########
 File path: airflow/contrib/hooks/gcs_hook.py
 ##########
 @@ -172,8 +172,9 @@ def download(self, bucket_name, object_name, filename=None):
         if filename:
             blob.download_to_filename(filename)
             self.log.info('File downloaded to %s', filename)
-
-        return blob.download_as_string()
+            return filename
 
 Review comment:
   I think that the value of this result should be consistent. In both cases it should be the content/stream of the file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services