[allura:tickets] Re: #7856 Error looking up user by email address when email is invalid

[Igor Bondarenko <je...@gmail.com>]

Hm.. probably you're right. Seems like regexp does not catch this, but I don't see why immediately. I'll investigate more.


---

** [tickets:#7856] Error looking up user by email address when email is invalid**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-1 
**Created:** Wed Mar 18, 2015 02:06 PM UTC by Dave Brondsema
**Last Updated:** Mon Apr 20, 2015 05:39 PM UTC
**Owner:** Igor Bondarenko

With an author header like this: `Author: foobar@gmail.com <fo...@a9fa2536-c6e1-c3a1-1ef2-e4143cdeeb22>` you get this error:

~~~~
  File "/var/local/allura/Allura/allura/model/repository.py", line 943, in authored_user
    return User.by_email_address(self.authored.email)
  File "/var/local/allura/Allura/allura/model/auth.py", line 647, in by_email_address
    addrs = EmailAddress.find(dict(email=addr, confirmed=True))
  File "/var/local/allura/Allura/allura/model/auth.py", line 144, in find
    email = cls.canonical(q['email'])
  File "/var/local/allura/Allura/allura/model/auth.py", line 172, in canonical
    user, domain = addr.split('@')
ValueError: too many values to unpack
~~~~

This can cause a repo import to fail.  We should handle it better.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.