You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/07/12 21:49:34 UTC
Review Request 60815: Prefer leading instead of trailing spaces for
allocator log messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60815/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.
Repository: mesos
Description
-------
Prefer leading instead of trailing spaces for allocator log messages.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035
Diff: https://reviews.apache.org/r/60815/diff/1/
Testing
-------
Not a functional change.
Thanks,
Gastón Kleiman
Re: Review Request 60815: Prefer leading instead of trailing spaces
for allocator log messages.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60815/#review180423
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60524, 60721, 60525, 60815]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 12, 2017, 9:49 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60815/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 9:49 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prefer leading instead of trailing spaces for allocator log messages.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035
>
>
> Diff: https://reviews.apache.org/r/60815/diff/1/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 60815: Prefer leading instead of trailing spaces
for allocator log messages.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60815/#review182873
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.cpp
Lines 1173-1174 (original), 1173-1174 (patched)
<https://reviews.apache.org/r/60815/#comment258816>
Need to remove the trailing space.
- Greg Mann
On July 12, 2017, 9:49 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60815/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 9:49 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prefer leading instead of trailing spaces for allocator log messages.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035
>
>
> Diff: https://reviews.apache.org/r/60815/diff/3/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 60815: Prefer leading instead of trailing spaces
for allocator log messages.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60815/#review180360
-----------------------------------------------------------
Bad patch!
Reviews applied: [60815, 60525, 60721, 60524]
Failed command: python support/apply-reviews.py -n -r 60524
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 417, in <module>
main()
File "support/apply-reviews.py", line 412, in main
reviewboard(options)
File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 160, in apply_review
commit_patch(options)
File "support/apply-reviews.py", line 268, in commit_patch
shell(cmd, options['dry_run'])
File "support/apply-reviews.py", line 144, in shell
error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
File "C:\Python27\lib\subprocess.py", line 168, in call
return Popen(*popenargs, **kwargs).wait()
File "C:\Python27\lib\subprocess.py", line 390, in __init__
errread, errwrite)
File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128)
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/142/console
- Mesos Reviewbot Windows
On July 12, 2017, 9:49 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60815/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 9:49 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prefer leading instead of trailing spaces for allocator log messages.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035
>
>
> Diff: https://reviews.apache.org/r/60815/diff/1/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Gastón Kleiman
>
>