You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/06 03:04:28 UTC

[GitHub] [incubator-dolphinscheduler] ywywn opened a new issue #2599: [QUESTION] CONDITIONS task node usability issues

ywywn opened a new issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599


   **Describe the question**
       CONDITIONS is a pretty useful node, but there are some usability issues when I add additional condition with custom parameters. Logical judgment will appear even single condition, it make me confuse when use CONDITIONS firstly. Under a single condition, changing the logical judgment will not affect this part of the judgment.
   ![image](https://user-images.githubusercontent.com/26102201/81134447-6240eb00-8f87-11ea-8c9c-58f57a079d39.png)
   
   **Which version of DolphinScheduler:**
    -[dev]
   
   **Requirement or improvement**
   Logical judgment should be hidden when user just have single condition.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] misinong edited a comment on issue #2599: [QUESTION] CONDITIONS task node usability issues

Posted by GitBox <gi...@apache.org>.
misinong edited a comment on issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599#issuecomment-669718844


   How are conditional nodes used? When judging the task execution return code, whether 0 or -1, it will execute to the successful branch!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #2599: [QUESTION] CONDITIONS task node usability issues

Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599#issuecomment-722771755


   Use condition refer to #2652


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] xingchun-chen edited a comment on issue #2599: [QUESTION] CONDITIONS task node usability issues

Posted by GitBox <gi...@apache.org>.
xingchun-chen edited a comment on issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599#issuecomment-722771755


   Use condition node refer to #2652


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #2599: [QUESTION] CONDITIONS task node usability issues

Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599#issuecomment-625688602


   I don't quite understand what the problem is, can you describe it in detail


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2599: [QUESTION] CONDITIONS task node usability issues

Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599#issuecomment-625676829


   @xingchun-chen , please review this issue, thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] xingchun-chen closed issue #2599: [QUESTION] CONDITIONS task node usability issues

Posted by GitBox <gi...@apache.org>.
xingchun-chen closed issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] ywywn commented on issue #2599: [QUESTION] CONDITIONS task node usability issues

Posted by GitBox <gi...@apache.org>.
ywywn commented on issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599#issuecomment-625718257


   Sorry about describe unclearly. No matter which judgment (and / or) I choose in custom parameters, the workflow always turns to test-4, the judgment(red mark) does not affect the workflow when custom parameters contain single condition. Is it possible to consider hiding judgment (and / or)  when custom parameters contain single condition? I think this is a problem about ease of use, the priority of modification will not be very high.
   ![image](https://user-images.githubusercontent.com/26102201/81389880-1f307480-914d-11ea-922e-1020868e7370.png)
   ![image](https://user-images.githubusercontent.com/26102201/81389920-32434480-914d-11ea-83f8-4f5149042c40.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] misinong commented on issue #2599: [QUESTION] CONDITIONS task node usability issues

Posted by GitBox <gi...@apache.org>.
misinong commented on issue #2599:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2599#issuecomment-669718844


   How are conditional nodes used? When judging the task execution return code, whether 0 or 1, it will execute to the successful branch!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org