You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/29 18:16:30 UTC
[GitHub] [spark] warrenzhu25 opened a new pull request #30186: [SPARK-23432][UI]Add executor peak jvm memory metrics in executors page
warrenzhu25 opened a new pull request #30186:
URL: https://github.com/apache/spark/pull/30186
### What changes were proposed in this pull request?
Add executor peak jvm memory metrics in executors page
### Why are the changes needed?
Users can know executor peak jvm metrics on in executors page
### Does this PR introduce _any_ user-facing change?
Users can know executor peak jvm metrics on in executors page
### How was this patch tested?
Manually tested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30186: [SPARK-23432][UI]Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-718934290
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30186: [SPARK-23432][UI]Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-718934952
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722840687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721486851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722797615
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35293/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722797628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-720845266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30186: [SPARK-23432][UI]Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-718934290
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #30186:
URL: https://github.com/apache/spark/pull/30186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-720874715
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-720845266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721463836
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] warrenzhu25 commented on a change in pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
warrenzhu25 commented on a change in pull request #30186:
URL: https://github.com/apache/spark/pull/30186#discussion_r516384584
##########
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
##########
@@ -86,6 +86,22 @@ <h4 class="title-table">Executors</h4>
<span data-toggle="tooltip" data-placement="top"
title="Memory used / total available memory for off heap storage of data like RDD partitions cached in memory.">
Off Heap Storage Memory</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak onHeap / OffHeap memory used by JVM.">
+ Peak JVM Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak execution onHeap / OffHeap memory used by JVM.">
+ Peak Execution Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak storage onHeap / OffHeap memory used by JVM.">
+ Peak Storage Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak direct / mapped pool memory used by JVM.">
Review comment:
Good point. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722775464
retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722838495
**[Test build #130682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130682/testReport)** for PR 30186 at commit [`30da8f1`](https://github.com/apache/spark/commit/30da8f1d6160c9db33656e411763e2766dea96d8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-720874715
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] warrenzhu25 commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
warrenzhu25 commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-723163024
@HeartSaVioR thanks, it's correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722775711
**[Test build #130682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130682/testReport)** for PR 30186 at commit [`30da8f1`](https://github.com/apache/spark/commit/30da8f1d6160c9db33656e411763e2766dea96d8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721463836
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722775711
**[Test build #130682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130682/testReport)** for PR 30186 at commit [`30da8f1`](https://github.com/apache/spark/commit/30da8f1d6160c9db33656e411763e2766dea96d8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721486851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721486339
**[Test build #130580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130580/testReport)** for PR 30186 at commit [`30da8f1`](https://github.com/apache/spark/commit/30da8f1d6160c9db33656e411763e2766dea96d8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721445258
**[Test build #130580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130580/testReport)** for PR 30186 at commit [`30da8f1`](https://github.com/apache/spark/commit/30da8f1d6160c9db33656e411763e2766dea96d8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30186: [SPARK-23432][UI]Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-718963447
can you provide screen shots?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721445258
**[Test build #130580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130580/testReport)** for PR 30186 at commit [`30da8f1`](https://github.com/apache/spark/commit/30da8f1d6160c9db33656e411763e2766dea96d8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722840687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721455869
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35181/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722935367
Thanks! Merged into master.
@warrenzhu25 Could you please let me know your JIRA ID? I'm not 100% sure so I left the assignee as unassigned. Once I get the information I'll update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722797628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-721463826
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35181/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #30186:
URL: https://github.com/apache/spark/pull/30186#discussion_r516080247
##########
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
##########
@@ -86,6 +86,22 @@ <h4 class="title-table">Executors</h4>
<span data-toggle="tooltip" data-placement="top"
title="Memory used / total available memory for off heap storage of data like RDD partitions cached in memory.">
Off Heap Storage Memory</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak onHeap / OffHeap memory used by JVM.">
+ Peak JVM Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak execution onHeap / OffHeap memory used by JVM.">
+ Peak Execution Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak storage onHeap / OffHeap memory used by JVM.">
Review comment:
I think we should expand this to be "Peak onHeap/ OffHeap memory used for storage of data like RDD partitions cached in memory"
##########
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
##########
@@ -86,6 +86,22 @@ <h4 class="title-table">Executors</h4>
<span data-toggle="tooltip" data-placement="top"
title="Memory used / total available memory for off heap storage of data like RDD partitions cached in memory.">
Off Heap Storage Memory</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak onHeap / OffHeap memory used by JVM.">
+ Peak JVM Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak execution onHeap / OffHeap memory used by JVM.">
Review comment:
Peak OnHeap/OffHeap memory used for execution. This refers to memory used for computation in shuffles, joins, user data structures, etc. See the Memory Management Overview documentation for more details.
##########
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
##########
@@ -86,6 +86,22 @@ <h4 class="title-table">Executors</h4>
<span data-toggle="tooltip" data-placement="top"
title="Memory used / total available memory for off heap storage of data like RDD partitions cached in memory.">
Off Heap Storage Memory</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak onHeap / OffHeap memory used by JVM.">
+ Peak JVM Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak execution onHeap / OffHeap memory used by JVM.">
+ Peak Execution Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak storage onHeap / OffHeap memory used by JVM.">
+ Peak Storage Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak direct / mapped pool memory used by JVM.">
Review comment:
Similarly I think we should explain more or point to java docs.
At least say this is direct byte buffers and mapped are memory-mapped or perhaps better would be to point to java.nio:type=BufferPool,name=direct and java.nio:type=BufferPool,name=mapped
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #30186: [SPARK-23432][UI] Add executor peak jvm memory metrics in executors page
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722936210
Never mind. I tried your Github account and found it. Please let me know if I misassigned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org