[jira] Assigned: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.

["Scott Gray (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-880:
--------------------------------

    Assignee:     (was: Scott Gray)

There's now only 2 deprecated methods left in OrderReadHelper.java:
getShippingAddress()
getBillingAddress()

To be honest I really don't feel like dealing with those at the moment, so I'm going to unassign this issue for now.

> Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-880
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-880
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>
> Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
> It would be great to have this fixed before the upcoming release (volunteers?).
> Here is the list of the warnings:
> 13 warnings
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   double updatedTotal = orh.getOrderGrandTotal();
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping();
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping();
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments);
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true));
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true);
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true);
> applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true);
> applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   double orderSubTotal = orh.getOrderItemsSubTotal();
> applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true);
> applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated
>   shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.