[GitHub] [hadoop] liuml07 edited a comment on issue #1875: HADOOP-16794. S3A reverts KMS encryption to the bucket's default KMS …

[GitBox <gi...@apache.org>]

liuml07 edited a comment on issue #1875: HADOOP-16794. S3A reverts KMS encryption to the bucket's default KMS …
URL: https://github.com/apache/hadoop/pull/1875#issuecomment-596733566
 
 
   @steveloughran and @mukund-thakur 
   
   Per my [previous investigation](https://github.com/apache/hadoop/pull/1875#discussion_r389237849) in this review, I have backported the changes in HADOOP-16626 partially into `branch-3.2`. The backported change was to fix the problem of adding configuration resources unexpectedly. The test `ITestRestrictedReadAccess` was not there in `branch-3.2` yet so I ignored that file.
   
   Then I tested with `removeBaseAndBucketOverrides` when patching encryption configuration, it seems to work, at least for both `ITestS3AEncryptionWithDefaultS3Settings` and `ITestS3AEncryptionSSES3`.  The code is in my branch https://github.com/liuml07/hadoop/tree/HADOOP-16794.HADOOP-16626-branch-3.2 please see the latest two commits. I think we can run more tests to confirm this.
   
   Question: does this backport make sense to happen separately, or we can merge with this PR?
   
   
   
   So, what is the best way

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org