[GitHub] [buildstream] abderrahim commented on a diff in pull request #1741: Update install instructions for final BuildStream 2.0 release

[GitBox <gi...@apache.org>]

abderrahim commented on code in PR #1741:
URL: https://github.com/apache/buildstream/pull/1741#discussion_r956551512


##########
doc/source/main_install.rst:
##########
@@ -285,13 +327,23 @@ A regular way to do this is to add the following line to the end of your ``~/.ba
 
 .. _install-container:
 
-
 Buildstream Inside a Container
 -------------------------------
-If your system cannot provide the base requirements, it is possible to run
-BuildStream within a container. This gives you an easy way to get started
-using BuildStream on any Unix-like platform where containers are available,
-including macOS. 
 
-For details, see the `Buildstream Docker documentation
-<https://gitlab.com/BuildStream/buildstream-docker-images/-/blob/master/USING.md>`_
+It is possible to run BuildStream in an OCI container tool such as Docker.
+This gives you an easy way to get started using BuildStream on any Unix-like
+platform where containers are available, including macOS.
+
+Prebuilt images are available, see the documentation
+`here <https://gitlab.com/BuildStream/buildstream-docker-images/-/blob/master/USING.md>`_
+
+You can also produce your own container images, either by adapting the
+`buildstream-docker-images project <https://gitlab.com/BuildStream/buildstream-docker-images/>`_,
+or by following the full installation instructions above.
+
+Note that some special configuration is often needed to run BuildStream in a container:
+
+  * User namespaces are used to isolate and control builds. This requires the
+    Docker ``--privileged`` mode.

Review Comment:
   @nanonyme AFAIK toolbx uses a `--privileged` podman container. You're probably confusing rootless with non-privileged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org