You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2018/05/31 09:47:58 UTC
[myfaces-tobago] branch master updated: improve docker-qunit-tests:
fix firefox crashes
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
The following commit(s) were added to refs/heads/master by this push:
new ffe1d96 improve docker-qunit-tests: fix firefox crashes
ffe1d96 is described below
commit ffe1d96895647b11eee5903cded280dafd309d41
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Thu May 31 11:46:51 2018 +0200
improve docker-qunit-tests: fix firefox crashes
* set shmSize to 2gb (arbitrary value)
* update com.google.guava dependency
* remove unnecessary DesiredCapabilities for browser setup
---
tobago-example/tobago-example-demo/pom.xml | 4 +++-
.../org/apache/myfaces/tobago/example/demo/qunit/SeleniumBase.java | 4 +---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tobago-example/tobago-example-demo/pom.xml b/tobago-example/tobago-example-demo/pom.xml
index 2988b08..3dcfa00 100644
--- a/tobago-example/tobago-example-demo/pom.xml
+++ b/tobago-example/tobago-example-demo/pom.xml
@@ -154,7 +154,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
- <version>25.0-jre</version>
+ <version>25.1-jre</version>
</dependency>
</dependencies>
</dependencyManagement>
@@ -872,6 +872,8 @@
<ports>
<port>5557:5555</port>
</ports>
+ <!-- Set shm size to avoid firefox crashes: https://github.com/SeleniumHQ/docker-selenium/tree/3.12.0-boron#running-the-images -->
+ <shmSize>2147483648</shmSize>
<wait>
<http>
<url>http://localhost:5557</url>
diff --git a/tobago-example/tobago-example-demo/src/test/java/org/apache/myfaces/tobago/example/demo/qunit/SeleniumBase.java b/tobago-example/tobago-example-demo/src/test/java/org/apache/myfaces/tobago/example/demo/qunit/SeleniumBase.java
index 7e85ad1..98ac78b 100644
--- a/tobago-example/tobago-example-demo/src/test/java/org/apache/myfaces/tobago/example/demo/qunit/SeleniumBase.java
+++ b/tobago-example/tobago-example-demo/src/test/java/org/apache/myfaces/tobago/example/demo/qunit/SeleniumBase.java
@@ -28,7 +28,6 @@ import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.chrome.ChromeOptions;
import org.openqa.selenium.firefox.FirefoxOptions;
-import org.openqa.selenium.remote.DesiredCapabilities;
import org.openqa.selenium.remote.RemoteWebDriver;
import org.openqa.selenium.support.ui.ExpectedConditions;
import org.openqa.selenium.support.ui.FluentWait;
@@ -76,8 +75,7 @@ abstract class SeleniumBase {
options = new FirefoxOptions();
break;
}
-
- webDriver = new RemoteWebDriver(new URL("http://localhost:4444/wd/hub"), new DesiredCapabilities(options));
+ webDriver = new RemoteWebDriver(new URL("http://localhost:4444/wd/hub"), options);
}
void setupWebDriver(final String portContextPath, final String path, final boolean accessTest)
--
To stop receiving notification emails like this one, please contact
hnoeth@apache.org.