You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/12/27 18:37:05 UTC
[arrow] branch master updated: ARROW-4080: [Rust] Improving lengthy
build times in Appveyor
This is an automated email from the ASF dual-hosted git repository.
wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 83a4e97 ARROW-4080: [Rust] Improving lengthy build times in Appveyor
83a4e97 is described below
commit 83a4e979271535b74de9870289cf99d02f6eb16b
Author: Chao Sun <su...@apache.org>
AuthorDate: Thu Dec 27 12:36:54 2018 -0600
ARROW-4080: [Rust] Improving lengthy build times in Appveyor
This tries to cut the build times by skipping:
1. build for stable (it doesn't seem too useful).
1. benchmarks in travis
2. build for dev profiles in windows CI - now we only build with release
profiles.
Author: Chao Sun <su...@apache.org>
Closes #3231 from sunchao/ARROW-4080 and squashes the following commits:
f5956404 <Chao Sun> Disable some flaky doctests
60f8b7d2 <Chao Sun> ARROW-4080: Improving lengthy build times in Appveyor
---
.travis.yml | 1 -
ci/rust-build-main.bat | 20 --------------------
ci/travis_script_rust.sh | 1 -
rust/src/parquet/column/mod.rs | 4 ++--
rust/src/parquet/file/mod.rs | 8 ++++----
5 files changed, 6 insertions(+), 28 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 99ff24a..b37194f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -282,7 +282,6 @@ matrix:
- if [ $ARROW_CI_RUST_AFFECTED != "1" ]; then exit; fi
- $TRAVIS_BUILD_DIR/ci/travis_install_cargo.sh
script:
- - RUSTUP_TOOLCHAIN=stable $TRAVIS_BUILD_DIR/ci/travis_script_rust.sh || true
- RUSTUP_TOOLCHAIN=nightly $TRAVIS_BUILD_DIR/ci/travis_script_rust.sh
after_success:
- pushd ${TRAVIS_BUILD_DIR}/rust
diff --git a/ci/rust-build-main.bat b/ci/rust-build-main.bat
index e338f7e..6ef4512 100644
--- a/ci/rust-build-main.bat
+++ b/ci/rust-build-main.bat
@@ -23,32 +23,12 @@ set PARQUET_TEST_DATA=%CD%\cpp\submodules\parquet-testing\data
pushd rust
@echo ===================================
-@echo Build with stable toolchain
-@echo ===================================
-
-rustup default stable
-rustup show
-cargo build --target %TARGET%
-cargo build --target %TARGET% --release
-@echo Test (debug)
-@echo ------------
-cargo test --target %TARGET%
-@echo
-@echo Test (release)
-@echo --------------
-cargo test --target %TARGET% --release
-
-@echo ===================================
@echo Build with nightly toolchain
@echo ===================================
rustup default nightly
rustup show
-cargo build --target %TARGET% || exit /B
cargo build --target %TARGET% --release || exit /B
-@echo Test (debug)
-@echo ------------
-cargo test --target %TARGET% || exit /B
@echo
@echo Test (release)
@echo --------------
diff --git a/ci/travis_script_rust.sh b/ci/travis_script_rust.sh
index 4b09bc2..af61dd3 100755
--- a/ci/travis_script_rust.sh
+++ b/ci/travis_script_rust.sh
@@ -36,7 +36,6 @@ cargo rustc -- -D warnings
cargo build
cargo test
-cargo bench
cargo run --example builders
cargo run --example dynamic_types
cargo run --example read_csv
diff --git a/rust/src/parquet/column/mod.rs b/rust/src/parquet/column/mod.rs
index 09c4bde..4ced32e 100644
--- a/rust/src/parquet/column/mod.rs
+++ b/rust/src/parquet/column/mod.rs
@@ -35,7 +35,7 @@
//! The example uses column writer and reader APIs to write raw values, definition and
//! repetition levels and read them to verify write/read correctness.
//!
-//! ```rust
+//! ```rust,no_run
//! use std::{fs, path::Path, rc::Rc};
//!
//! use arrow::parquet::{
@@ -48,7 +48,7 @@
//! schema::parser::parse_message_type,
//! };
//!
-//! let path = Path::new("target/debug/examples/column_sample.parquet");
+//! let path = Path::new("/path/to/column_sample.parquet");
//!
//! // Writing data using column writer API.
//!
diff --git a/rust/src/parquet/file/mod.rs b/rust/src/parquet/file/mod.rs
index ebaebba..38fe8fa 100644
--- a/rust/src/parquet/file/mod.rs
+++ b/rust/src/parquet/file/mod.rs
@@ -26,7 +26,7 @@
//!
//! # Example of writing a new file
//!
-//! ```rust
+//! ```rust,no_run
//! use std::{fs, path::Path, rc::Rc};
//!
//! use arrow::parquet::{
@@ -37,7 +37,7 @@
//! schema::parser::parse_message_type,
//! };
//!
-//! let path = Path::new("target/debug/examples/sample.parquet");
+//! let path = Path::new("/path/to/sample.parquet");
//!
//! let message_type = "
//! message schema {
@@ -61,11 +61,11 @@
//! ```
//! # Example of reading an existing file
//!
-//! ```rust
+//! ```rust,no_run
//! use arrow::parquet::file::reader::{FileReader, SerializedFileReader};
//! use std::{fs::File, path::Path};
//!
-//! let path = Path::new("target/debug/examples/sample.parquet");
+//! let path = Path::new("/path/to/sample.parquet");
//! if let Ok(file) = File::open(&path) {
//! let file = File::open(&path).unwrap();
//! let reader = SerializedFileReader::new(file).unwrap();