You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/04 10:08:37 UTC

[GitHub] [cloudstack-primate] PaulAngus opened a new issue #490: [BUG] Create VM Form - root disk size dialog is misleading

PaulAngus opened a new issue #490:
URL: https://github.com/apache/cloudstack-primate/issues/490


   **Describe the bug**
   
   The implementation of the root disk slider suggests that the user MUST set a root disk size. This has two problems:
   
   1. This is not the case and setting a root disk size is conpletely optional and not always possible.
   2. User will not know the original root disk size, and setting a root disk size smaller than the original disk will fail the deployment.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   
   1. Log in as: User
   2. Go to 'Create Instance'
   3. Select any zone
   4. See Root disk slider
   
   **Expected behavior**
   
   A clear indication that this is optional is required.
   
   **Screenshots**
   
   ![image](https://user-images.githubusercontent.com/4810220/86509967-deb74500-bde3-11ea-81b7-69ea9f5f1aa5.png)
   
   **Desktop (please complete the following information):**
    - OS: [e.g. Windows, Mac, iOS, Android with device/screen details if applicable]
    - Browser [e.g. chrome, safari]
    - Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-primate] rhtyd closed issue #490: [BUG] Create VM Form - root disk size dialog is misleading

Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #490:
URL: https://github.com/apache/cloudstack-primate/issues/490


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-primate] PaulAngus commented on issue #490: [BUG] Create VM Form - root disk size dialog is misleading

Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #490:
URL: https://github.com/apache/cloudstack-primate/issues/490#issuecomment-654765537


   reviewed on-screen with DJ - fix  LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-primate] rhtyd commented on issue #490: [BUG] Create VM Form - root disk size dialog is misleading

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #490:
URL: https://github.com/apache/cloudstack-primate/issues/490#issuecomment-654119031


   With @davidjumani 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #490: [BUG] Create VM Form - root disk size dialog is misleading

Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on issue #490:
URL: https://github.com/apache/cloudstack-primate/issues/490#issuecomment-653832405


   With @davidjumani 
   - listTemplates returns `size` check and use that to validate root disk size (must be equal to or greater than template size/physical size)
   - Remove slider, keep it simply a number input
   - Perhaps discuss and add a switch to say override root disk size and then show the label/input (i.e. don't show it by default, a toggle/switch shows the input)
   
   Except for the slider part, the UX and feature is exactly like the old UI; lowered priority to Major.
   Last time I tested the feature is supported all KVM, VMware (maybe only scsi root disks) and XenServer, @davidjumani please also explore if it's possible to evaluate if we should show the option for specific template/hypervisor combination?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-primate] rhtyd commented on issue #490: [BUG] Create VM Form - root disk size dialog is misleading

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #490:
URL: https://github.com/apache/cloudstack-primate/issues/490#issuecomment-653832405


   With @davidjumani 
   - listTemplates returns `size` check and use that to validate root disk size (must be equal to or greater than template size/physical size)
   - Remove slider, keep it simply a number input
   - Perhaps discuss and add a switch to say override root disk size and then show the label/input (i.e. don't show it by default, a toggle/switch shows the input)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org