[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2655: ARTEMIS-2327 ExceptionListener invoked when connection level exception

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2655: ARTEMIS-2327 ExceptionListener invoked when connection level exception
URL: https://github.com/apache/activemq-artemis/pull/2655#discussion_r280012906
 
 

 ##########
 File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
 ##########
 @@ -451,7 +451,9 @@ public Packet sendBlocking(final Packet packet,
             }
 
             if (response == null) {
-               throw ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(), packet.getType());
+               ActiveMQException e = ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(), packet.getType());
+               connection.fail(e);
 
 Review comment:
   So i ran a few of them in the normal int tests (didnt run any extra tests tho). Happy for you to run more if you like 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services