You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/09/24 21:54:20 UTC

[GitHub] [pulsar] jerrypeng commented on a change in pull request #5271: Improve error handling logic for effectively once

jerrypeng commented on a change in pull request #5271: Improve error handling logic for effectively once
URL: https://github.com/apache/pulsar/pull/5271#discussion_r327851165
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
 ##########
 @@ -125,7 +129,8 @@
 public class PersistentTopic extends AbstractTopic implements Topic, AddEntryCallback {
 
     // Managed ledger associated with the topic
-    protected final ManagedLedger ledger;
+    @VisibleForTesting
+    ManagedLedger ledger;
 
 Review comment:
   will change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services