You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Hari Sankar Sivarama Subramaniyan (JIRA)" <ji...@apache.org> on 2014/03/20 22:05:43 UTC
[jira] [Commented] (HIVE-6708) ConstantVectorExpression should
create copies of data objects rather than referencing them
[ https://issues.apache.org/jira/browse/HIVE-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942276#comment-13942276 ]
Hari Sankar Sivarama Subramaniyan commented on HIVE-6708:
---------------------------------------------------------
https://reviews.apache.org/r/19456/
> ConstantVectorExpression should create copies of data objects rather than referencing them
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-6708
> URL: https://issues.apache.org/jira/browse/HIVE-6708
> Project: Hive
> Issue Type: Bug
> Reporter: Hari Sankar Sivarama Subramaniyan
> Assignee: Hari Sankar Sivarama Subramaniyan
> Attachments: HIVE-6708-1.patch
>
>
> 1. ConstantVectorExpression vector should be updated for bytecolumnvectors and decimalColumnVectors. The current code changes the reference to the vector which might be shared across multiple columns
> 2. VectorizationContext.foldConstantsForUnaryExpression(ExprNodeDesc exprDesc) has a minor bug as to when to constant fold the expression.
> The following code should replace the corresponding piece of code in the trunk.
> ..
> GenericUDF gudf = ((ExprNodeGenericFuncDesc) exprDesc).getGenericUDF();
> if (gudf instanceof GenericUDFOPNegative || gudf instanceof GenericUDFOPPositive
> || castExpressionUdfs.contains(gudf.getClass())
> ...
--
This message was sent by Atlassian JIRA
(v6.2#6252)