You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by rahulforallp <gi...@git.apache.org> on 2017/10/13 14:52:23 UTC
[GitHub] carbondata pull request #1414: [CARBONDATA-1574] No_Inverted is applied for ...
GitHub user rahulforallp opened a pull request:
https://github.com/apache/carbondata/pull/1414
[CARBONDATA-1574] No_Inverted is applied for all newly added column i…
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-1574
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1414.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1414
----
commit c57a8e25c553b3630f04f9f9daa21920510ea987
Author: rahulforallp <ra...@knoldus.in>
Date: 2017-10-13T13:48:53Z
[CARBONDATA-1574] No_Inverted is applied for all newly added column irrespect of specified in tableproperties
----
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1074/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/1414
retest this please
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/456/
---
[GitHub] carbondata pull request #1414: [CARBONDATA-1574] No_Inverted is applied for ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1414#discussion_r145858506
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/test/util/QueryTest.scala ---
@@ -58,6 +58,17 @@ class QueryTest extends PlanTest {
}
}
+ /**
+ * Runs the plan and counts the keyword in the answer
+ * @param df the [[DataFrame]] to be executed
+ * @param count expected count
+ * @param keyword keyword to search
+ */
+ def checkExistenceCount(df: DataFrame, count: Long, keyword: String): Unit = {
+ val outputs = df.collect().map(_.mkString).mkString
+ assert(outputs.sliding(keyword.length).count(_ == keyword) == count)
--- End diff --
Can you use assertEqual so that console will show the correct answer if the testcase failed
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/1414
@jackylk please merge this PR
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/321/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1281/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/331/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/446/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1095/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1081/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
LGTM
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/721/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1084/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/453/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/320/
---
[GitHub] carbondata pull request #1414: [CARBONDATA-1574] No_Inverted is applied for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1414
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1073/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/328/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/1414
retest this please
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1696/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/545/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/651/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1358/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1414
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/445/
---
[GitHub] carbondata pull request #1414: [CARBONDATA-1574] No_Inverted is applied for ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1414#discussion_r146222793
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/test/util/QueryTest.scala ---
@@ -58,6 +58,17 @@ class QueryTest extends PlanTest {
}
}
+ /**
+ * Runs the plan and counts the keyword in the answer
+ * @param df the [[DataFrame]] to be executed
+ * @param count expected count
+ * @param keyword keyword to search
+ */
+ def checkExistenceCount(df: DataFrame, count: Long, keyword: String): Unit = {
+ val outputs = df.collect().map(_.mkString).mkString
+ assert(outputs.sliding(keyword.length).count(_ == keyword) == count)
--- End diff --
@jackylk We can use === instead of assertEqual(available in junit) in Funsuite. I have replaced the same.
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/1414
@jackylk please review and merge
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1414
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1176/
---
[GitHub] carbondata issue #1414: [CARBONDATA-1574] No_Inverted is applied for all new...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/1414
retest this please
---