You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/24 17:58:56 UTC
[GitHub] [camel-k] johnpoth opened a new pull request #2592: Kamelet binding sbo
johnpoth opened a new pull request #2592:
URL: https://github.com/apache/camel-k/pull/2592
<!-- Description -->
Fixes #2566
Thanks !
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #2592: Kamelet binding sbo
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2592:
URL: https://github.com/apache/camel-k/pull/2592#issuecomment-905464255
> Ahh just noticed you assigned yourself the issue yesterday @squakez ... let me know if you have something and I'll close the PR... sorry...
No problem, I did not start developing though I was having some ideas about it. As [commented in the issue](https://github.com/apache/camel-k/issues/2566#issuecomment-903859299), I think we should develop something generic to allow any trait management, instead of focusing on the specific `ServiceBinding` trait. We surely have the need to include `trait` configuration in a `KameletBinding`, so I guess it's better to have a unique way instead of polluting with each trait option. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #2592: Kamelet binding sbo
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2592:
URL: https://github.com/apache/camel-k/pull/2592#issuecomment-922900587
@johnpoth this is standing since a while, can we commit or are you still planning changes to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] johnpoth commented on pull request #2592: Kamelet binding sbo
Posted by GitBox <gi...@apache.org>.
johnpoth commented on pull request #2592:
URL: https://github.com/apache/camel-k/pull/2592#issuecomment-904876985
Ahh just noticed you assigned yourself the issue yesterday @squakez ... let me know if you have something and I'll close the PR... sorry...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #2592: Kamelet binding sbo
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #2592:
URL: https://github.com/apache/camel-k/pull/2592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez edited a comment on pull request #2592: Kamelet binding sbo
Posted by GitBox <gi...@apache.org>.
squakez edited a comment on pull request #2592:
URL: https://github.com/apache/camel-k/pull/2592#issuecomment-922900587
@johnpoth this is standing since a while, can we merge or are you still planning changes to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] johnpoth commented on pull request #2592: Kamelet binding sbo
Posted by GitBox <gi...@apache.org>.
johnpoth commented on pull request #2592:
URL: https://github.com/apache/camel-k/pull/2592#issuecomment-905512559
@squakez for sure! Tracked with #2596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org